407490 - Reconnect in N seconds message shows up even if we won't reconnect

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[:Gijs (he/him)]

As in summary. The code at http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/extensions/irc/xul/content/handlers.js&rev=1.158?mark2026-2054#2011 should probably check the "reconnect" pref. The irc.js code which actually reconnects already checks net.stayingPower (which reflects the pref) so the result is ok, it's just the msg which sucks.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Weee.

Comment 2

[James Ross]

Comment on attachment 295627 [details] [diff] [review]
Patch

I think this code is ok, test before landing if you haven't already.

Comment 3

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/handlers.js;
/cvsroot/mozilla/extensions/irc/xul/content/handlers.js,v  <--  handlers.js
new revision: 1.163; previous revision: 1.162
done
Checking in mozilla/extensions/irc/xul/content/prefs.js;
/cvsroot/mozilla/extensions/irc/xul/content/prefs.js,v  <--  prefs.js
new revision: 1.48; previous revision: 1.47
done