407505 - "Corrupt" images in third-party themes can cause exceptions and break bookmarking

Status: RESOLVED WONTFIX

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'm not sure if this is something we can fix, but to me it sounds like it would help if we had some extra bullet-proofing in parts of our code, even though the trigger is a 3rd-party image, not one of our own.

It seems that if you have an image that NSImage can't read, we throw at some point

2007-12-08 21:25:47.906 Camino[11007] Exception raised during posting of notification.  Ignored.  exception: Can't cache image
2007-12-08 21:25:50.963 Camino[11007] Can't cache image
2007-12-08 21:25:56.568 Camino[11007] Can't cache image

and it is possible to then be in a state where you can't bookmark (maybe what's broken depends on what image is bad? Or maybe this is another part of the bookmarks system mis-using exceptions?)

Comment 1

[Stuart Morgan]

I'm not at all convinced that bullet-proofing every single image load we do from our own bundle just to make the pathological case of a corrupted application bundle less painful is worthwhile. I think "If you replace parts of Camino.app's internals with broken bits, Camino isn't going to work" is a perfectly reasonable behavior.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

No one else has disagreed with Stuart here, and his position is perfectly reasonable, so WF.