407529 - Show mode as symbol doesn't update display

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[:Gijs (he/him)]

NOTE: TRUNK CHATZILLA, BRANCH FIREFOX, rather than bug 406316 which is about stable chatzilla and firefox trunk.


So we have a JS tree view now. And we're calling treeElem.treeBoxObject.clearStyleAndImageCaches() and it doesn't seem to help - the tree is still not getting updated if you do:

STR:
1. Open ChatZilla, join channel
2. Right click userlist, click "show mode as symbol"

ER:
Entire list is displayed differently (symbols rather than light bulbs, or vice versa)

AR:
List is not updated, though selected items are. The entire tree updates if you switch to a different tab and back.



This bug will in all likelihood move to Core ASAP, but as I haven't figured out why it doesn't work yet...

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Need to call invalidate() too, trees don't think.

Comment 2

[:Gijs (he/him)]

(In reply to comment #1)
> Created an attachment (id=292257) [details]
> Patch
> 
> Need to call invalidate() too, trees don't think.
> 

I also need to not typo.

s/treebox/treeBox/

duh.

Comment 3

[James Ross]

Comment on attachment 292257 [details] [diff] [review]
Patch

r=silver with that fixed.

Comment 4

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/content/static.js;
/cvsroot/mozilla/extensions/irc/xul/content/static.js,v  <--  static.js
new revision: 1.253; previous revision: 1.252
done