407536 - don't prompt for software update unless firefox is the foreground application

Status: RESOLVED INCOMPLETE

(Toolkit :: Application Update, defect)

Description

[(not reading, please use [e-mail] instead)]

don't prompt for software update unless firefox 3 is the foreground application

dao already made it so we don't prompt unless we're idle, see bug #323041

screen shot coming of why this would be good.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[Jesse Ruderman]

This image is also the topic of bug 406394.

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 292258 [details]
screen shot

Do we know that Firefox isn't the foreground application here?

Comment 4

[(not reading, please use [e-mail] instead)]

> Do we know that Firefox isn't the foreground application here?

that's a good point, this could be a full screen web app in kiosk mode.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

I think that this bug is a little misguided and reacting to a corner case. When we run Firefox in kiosk mode, we should probably flip app.update.silent to true and just never show the modal, since that's consistant with kiosk mode needs (that would require another bug).

By default, we totally want Firefox to pop the update dialog when the app is in the background, we just don't want it to make that take UI focus from the OS. To the best of my knowledge (and I won't be able to test this until tomorrow) that's actually already what we do. The window opens (flashing the taskbar on w32) and when the user switches back to the app, the modal has focus.

Can we get a confirmation that we actually grab focus away from other apps before we block on this?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Dao, isn't that already solved yet?

Comment 7

[Dão Gottwald [:dao]]

We've done some things to improve update prompting, but it's not really clear what attachment 292258 [details] is showing.

A new bug could be filed for the first part of comment 5.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

So the modal dialog still pops-up in some situations? I haven't seen it automatically open since the global notification is used.

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #8)
> So the modal dialog still pops-up in some situations?

Yes, if the update wasn't applied after 24 hours or so.

Comment 10

[Dão Gottwald [:dao]]

It's a window though, not a modal dialog...

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

(In reply to comment #9)
> Yes, if the update wasn't applied after 24 hours or so.

As I already have pointed out on another bug I don't see the update dialog at all. Which prefs I have to set?

Comment 12

[Dão Gottwald [:dao]]

The default values for the update prefs should be fine. The window will only appear when the user isn't doing anything.