407544 - Clean up download event handling

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Stuart Morgan]

Attachment: fix

The notification-based event handling system in the download manager is rather confusing. This changes it to do all the translation of the event into a conceptual action in the view, but nothing more, and then passes that off to its controller (which in this case just passes it up to the window controller). That seems like a better view/controller division, and it removes the weird dance with notifications and stored modifier keys.

This doesn't fix everything about the interaction of the download classes, but it's a step.

Comment 1

[Mark Mentovai]

Comment on attachment 292265 [details] [diff] [review]
fix

>+#import "ProgressViewController.h"; // For DownloadSelectionBehavior enum

Well, it's also for ProgressViewController.

I don't think the comment's necessary.

Looks fine otherwise.

Comment 2

[Stuart Morgan]

@class is all that's necessary for the .h file; I was commentating because it makes it easier to see that it's not a mistake that I didn't just use @class.

Comment 3

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH. I left the comment due largely to the fact that I forgot about taking it out until I came to post the checkin notice here :P If you care, I can take it out.