407563 - 'Fill Form' puts full name in a 'Surname' field

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Jolin Warren]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.11) Gecko/20071128 Camino/1.5.4 (MultiLang)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.11) Gecko/20071128 Camino/1.5.4 (MultiLang)

I use the automatic 'Fill Form' feature a lot because it is so useful. However, whenever I am on a page that has a 'First Name' and a 'Surname' field, Camino correctly puts my first name in the 'First Name' field but it puts my first+surname name in the 'Surname' field. Obviously, it should only put my surname in the 'Surname' field. This has been a problem for a long time and on many sites, but I have only just now got around to reporting it.

Reproducible: Always

Steps to Reproduce:
1. Go to URL specified in bug report. This is just an example, it will happen on any web form with a 'surname' field.

2. Hit cmd-opt-F or choose 'Fill Form' from the 'Edit' menu.

3. Notice that your whole name has been entered in the surname field instead of just your surname.
Actual Results:  
'Surname' field has "Jolin Warren".

Expected Results:  
'Surname' field should have "Warren".

Comment 1

[Chris Lawson (gone)]

Confirming; I can repro in the latest trunk.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This is probably fixable with a tweak to one of the wallet tables; if I get some time, I'll look and see while I have that code sort-of fresh in my mind.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Adds surname

Yup, we just need to add "surname" as an entry for $name.last in SchemaStrings.tbl (I really wish someone had written some documentation on how this wallet mess worked, or that pink had written form fill based on something more sane that wallet, but if wishes were horses, I'd have an enormous herd).

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The current newsletter signup URL is https://tickets.eastcoast.co.uk/ec/en/account/newslettersignup (amazing, it still exists 4 years later!); ideally we'd get a local testcase attached here, too, but I'm out of time for the moment.

Comment 5

[philippe (part-time)]

Comment on attachment 559548 [details] [diff] [review]
Adds surname

Does what it says on the box (with the linked page and a soon-to-be-attached testcase).

Comment 6

[philippe (part-time)]

Attachment: test case

Comment 7

[Stuart Morgan]

Comment on attachment 559548 [details] [diff] [review]
Adds surname

rs=smorgan

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/090e7f8ba949