40761 - Make the filter UI accessible

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[laurel]

refer to message filters ui spec:
http://gooey/client/5.0/specs/mail/filters/Filters.html

Mnenmonics have been added in the current revision of the filter ui spec.
Please implement -- Win32 for sure. What about linux? 4.x had mnemonics in
menus, but not in dialogs (at least I haven't found any). Mac not applicable.

Comment 1

[Alec Flett]

everything is cross-platform, even mneomimcs, I couldn't implement it on 'just 
win32' if I tried :)

Comment 2

[Alec Flett]

->gayatrib

Comment 3

[Håkan Waara]

OS -> All
Platform -> All

Comment 4

[scottputterman]

reassigning to naving

Comment 5

[Håkan Waara]

Jglick, are all the mnemonics up to date?

Comment 6

[jglick]

http://www.mozilla.org/mailnews/specs/filters/

Yeah, mnemonics are all there except "New Folder" on Filter Runs. "N" seems to 
be available for that.

Comment 7

[Håkan Waara]

Jglick, I talked to trudelle. Were you aware that accesskey support is not
implemented for XUL, but only for HTML?

Are you even able to trigger an accesskey?

Seems like all our "support" for accesskeys in Mailnews is totally bogus!

Comment 8

[jglick]

No I was not aware. Guess this will have to wait.

Comment 9

[Håkan Waara]

jglick: that (implemention of accesskeys for XUL) is bug 959 if you are interested.

Comment 10

[Håkan Waara]

Taking

Comment 11

[Håkan Waara]

triaging

Comment 12

[Håkan Waara]

Ssu, wanna take this too? :-)

Comment 13

[Sean Su]

hwaawa, did trudelle mention which bug would fix access keys in xul?  I'm
gessing it might be the infamous bug 959.

Comment 14

[Håkan Waara]

Yes, that's the one. Poke jag so he will make a new patch and check it in. :-)

Comment 15

[Håkan Waara]

Attachment: Patch

Now that bug 959 is fixed, this makes sense to fix.

This adds accesskeys to all filter controls, per the spec. I also fixed a
wording that was not according to the spec.

Note that until bug 90406 is resolved, accesskeys don't work for radiobuttons.

Comment 16

[Sean Su]

Comment on attachment 72299 [details] [diff] [review]
Patch

cool! we have keyboard accessibility!
r=ssu

Comment 17

[(not reading, please use [e-mail] instead)]

this looks good, except for the change to searchTermOverlay.dtd

I think that will case problems in the advanced message search dialog and the
advanced addressbook search dialog.

http://www.mozilla.org/mailnews/specs/search/images/Search1b.gif
http://www.mozilla.org/mailnews/specs/addressbook/images/AdvSearch1.gif
http://www.mozilla.org/mailnews/specs/filters/images/Filter2.gif

jglick, should all these dialogs look the same?  If so, which dialogs should change?

sr=sspitzer for everything else besides the change to searchTermOverlay.dtd

If this is possible, don't check that part in, but check the rest in.

make sure to test well (and to test with out the serachTermOverlay.dtd part.)

For the searchTermOverlay.dtd part, we need jglick to decide how similar these
three dialogs should be.

Comment 18

[jglick]

Håkan was trying to fix the fact that the word "match" is duplicated in the 
Filter Rules dialog.

So the same text strings are being used for the radio buttons in these three 
dialogs?

If that is the case, leave the radio buttons as "Match all of the following" and 
"Match any of the following" for the three windows/dialogs.

The descriptive text above the radio buttons for Filter Rules needs to be 
changed from "For incoming messages that match:" to "For incoming message that:" 
so that the word "match" isn't repeated.

Comment 19

[Håkan Waara]

Attachment: Patch v2

Without the searchTermOverlay changes.	I'll attach a patch later to fix
jglick's wording nit.

Comment 20

[Håkan Waara]

Comment on attachment 72775 [details] [diff] [review]
Patch v2

Carrying over the reviews.

Comment 21

[Håkan Waara]

Seth, if it's OK with you, I'll just sneak in this tiny change into the final
patch (which will fix jglick's nit):

FilterEditor.dtd:
-<!ENTITY conditionDesc.label "For incoming messages that match:">
+<!ENTITY conditionDesc.label "For incoming messages that:">

Comment 22

[Asa Dotzler [:asa]]

Comment on attachment 72775 [details] [diff] [review]
Patch v2

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 23

[Håkan Waara]

fixed.

Comment 24

[laurel]

Filter rules "Filter name" field mnemonic is shown in spec as f, in today's
build as i  -- Any problem with that jglick, anyone?

Comment 25

[jglick]

http://www.mozilla.org/mailnews/specs/filters/images/Filter2.gif
Laurel, I see "i" being used. Am i missing something?

Comment 26

[laurel]

Guess I was seeing things. Marking verified wiht mar08 commercial trunk.