407733 - [1.8 branch] js-1.7.0.tar.gz does not build on WIN32

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Robin Ehrlich]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
Build Identifier: 1.7

I get the following link errors when I just untar and run

nmake -f js.mak

   Creating library .\Debug/js32.lib and object .\Debug/js32.exp
jsapi.obj : error LNK2001: unresolved external symbol _js_GeneratorClass
jsapi.obj : error LNK2001: unresolved external symbol _js_IteratorClass
jsapi.obj : error LNK2001: unresolved external symbol _js_StopIterationClass
jsapi.obj : error LNK2001: unresolved external symbol _js_InitIteratorClasses
jsobj.obj : error LNK2001: unresolved external symbol _js_InitIteratorClasses
jsgc.obj : error LNK2001: unresolved external symbol _js_CloseGeneratorObject
jsgc.obj : error LNK2001: unresolved external symbol _js_CloseIteratorState
jsinterp.obj : error LNK2001: unresolved external symbol _js_NewGenerator
jsinterp.obj : error LNK2001: unresolved external symbol _js_CloseNativeIterator

jsinterp.obj : error LNK2001: unresolved external symbol _js_CallIteratorNext
jsinterp.obj : error LNK2001: unresolved external symbol _js_ValueToIterator

It seems jsiter.obj is not included.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 2

[Bob Clary [:bc] (inactive)]

Robin, sorry for the dupe. Reopening for 1.7.1 release off of the 1.8.1 branch.

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: patch

patch to add jsiter to js.mak.

builds with vc6 and vc8 for js and jsshell. vc8 warns on a bunch of different stuff, but this should be good enough.

Comment 4

[timeless]

Comment on attachment 339977 [details] [diff] [review]
patch

oops. i have this patch in a tree somewhere on my laptop :)

Comment 5

[Bob Clary [:bc] (inactive)]

Comment on attachment 339977 [details] [diff] [review]
patch

risk: not part of the build
reason: necessary for spidermonkey 1.7 source release.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 339977 [details] [diff] [review]
patch

Approved for 1.8.1.18, a=dveditz for release-drivers

Comment 7

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/src/js.mak,v  <--  js.mak
new revision: 3.9.8.2; previous revision: 3.9.8.1

Comment 8

[Al Billings [:abillings - ex-MoCo]]

(In reply to comment #0)
> User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR
> 1.1.4322; .NET CLR 2.0.50727)
> Build Identifier: 1.7
> 
> I get the following link errors when I just untar and run
> 
> nmake -f js.mak
> 
>    Creating library .\Debug/js32.lib and object .\Debug/js32.exp
> jsapi.obj : error LNK2001: unresolved external symbol _js_GeneratorClass
> jsapi.obj : error LNK2001: unresolved external symbol _js_IteratorClass
> jsapi.obj : error LNK2001: unresolved external symbol _js_StopIterationClass
> jsapi.obj : error LNK2001: unresolved external symbol _js_InitIteratorClasses
> jsobj.obj : error LNK2001: unresolved external symbol _js_InitIteratorClasses
> jsgc.obj : error LNK2001: unresolved external symbol _js_CloseGeneratorObject
> jsgc.obj : error LNK2001: unresolved external symbol _js_CloseIteratorState
> jsinterp.obj : error LNK2001: unresolved external symbol _js_NewGenerator
> jsinterp.obj : error LNK2001: unresolved external symbol
> _js_CloseNativeIterator
> 
> jsinterp.obj : error LNK2001: unresolved external symbol _js_CallIteratorNext
> jsinterp.obj : error LNK2001: unresolved external symbol _js_ValueToIterator
> 
> It seems jsiter.obj is not included.

Robin, can you confirm that it builds now with no issues?