Closed Bug 407733 Opened 15 years ago Closed 14 years ago

[1.8 branch] js-1.7.0.tar.gz does not build on WIN32

Categories

(Core :: JavaScript Engine, defect)

1.8 Branch
x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: rehrlich, Assigned: bc)

References

Details

(Keywords: fixed1.8.1.18)

Attachments

(1 file)

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
Build Identifier: 1.7

I get the following link errors when I just untar and run

nmake -f js.mak

   Creating library .\Debug/js32.lib and object .\Debug/js32.exp
jsapi.obj : error LNK2001: unresolved external symbol _js_GeneratorClass
jsapi.obj : error LNK2001: unresolved external symbol _js_IteratorClass
jsapi.obj : error LNK2001: unresolved external symbol _js_StopIterationClass
jsapi.obj : error LNK2001: unresolved external symbol _js_InitIteratorClasses
jsobj.obj : error LNK2001: unresolved external symbol _js_InitIteratorClasses
jsgc.obj : error LNK2001: unresolved external symbol _js_CloseGeneratorObject
jsgc.obj : error LNK2001: unresolved external symbol _js_CloseIteratorState
jsinterp.obj : error LNK2001: unresolved external symbol _js_NewGenerator
jsinterp.obj : error LNK2001: unresolved external symbol _js_CloseNativeIterator

jsinterp.obj : error LNK2001: unresolved external symbol _js_CallIteratorNext
jsinterp.obj : error LNK2001: unresolved external symbol _js_ValueToIterator

It seems jsiter.obj is not included.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Blocks: 401087
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 313059
Robin, sorry for the dupe. Reopening for 1.7.1 release off of the 1.8.1 branch.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Summary: js-1.7.0.tar.gz does not build on WIN32 → [1.8 branch] js-1.7.0.tar.gz does not build on WIN32
Version: unspecified → 1.8 Branch
Attached patch patchSplinter Review
patch to add jsiter to js.mak.

builds with vc6 and vc8 for js and jsshell. vc8 warns on a bunch of different stuff, but this should be good enough.
Assignee: general → bclary
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #339977 - Flags: review?(timeless)
Comment on attachment 339977 [details] [diff] [review]
patch

oops. i have this patch in a tree somewhere on my laptop :)
Attachment #339977 - Flags: review?(timeless) → review+
Flags: in-testsuite-
Flags: in-litmus-
Attachment #339977 - Flags: approval1.8.1.18?
Comment on attachment 339977 [details] [diff] [review]
patch

risk: not part of the build
reason: necessary for spidermonkey 1.7 source release.
Comment on attachment 339977 [details] [diff] [review]
patch

Approved for 1.8.1.18, a=dveditz for release-drivers
Attachment #339977 - Flags: approval1.8.1.18? → approval1.8.1.18+
/cvsroot/mozilla/js/src/js.mak,v  <--  js.mak
new revision: 3.9.8.2; previous revision: 3.9.8.1
Status: ASSIGNED → RESOLVED
Closed: 14 years ago14 years ago
Keywords: fixed1.8.1.18
Resolution: --- → FIXED
(In reply to comment #0)
> User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET CLR
> 1.1.4322; .NET CLR 2.0.50727)
> Build Identifier: 1.7
> 
> I get the following link errors when I just untar and run
> 
> nmake -f js.mak
> 
>    Creating library .\Debug/js32.lib and object .\Debug/js32.exp
> jsapi.obj : error LNK2001: unresolved external symbol _js_GeneratorClass
> jsapi.obj : error LNK2001: unresolved external symbol _js_IteratorClass
> jsapi.obj : error LNK2001: unresolved external symbol _js_StopIterationClass
> jsapi.obj : error LNK2001: unresolved external symbol _js_InitIteratorClasses
> jsobj.obj : error LNK2001: unresolved external symbol _js_InitIteratorClasses
> jsgc.obj : error LNK2001: unresolved external symbol _js_CloseGeneratorObject
> jsgc.obj : error LNK2001: unresolved external symbol _js_CloseIteratorState
> jsinterp.obj : error LNK2001: unresolved external symbol _js_NewGenerator
> jsinterp.obj : error LNK2001: unresolved external symbol
> _js_CloseNativeIterator
> 
> jsinterp.obj : error LNK2001: unresolved external symbol _js_CallIteratorNext
> jsinterp.obj : error LNK2001: unresolved external symbol _js_ValueToIterator
> 
> It seems jsiter.obj is not included.

Robin, can you confirm that it builds now with no issues?
You need to log in before you can comment on or make changes to this bug.