407744 - Get rid of useless toolbar_button_box

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

Some of our windows have an extra box wrapping their toolbar buttons which needs to be removed if we are to make them customisable.

Comment 1

[[e-mail]]

Attachment: Proposed patch

I didn't bother changing the indentation because we might need to change it again anyway when we make the toolbar customisable.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 292416 [details] [diff] [review]
Proposed patch

yep, looks good. r=me.

Comment 3

[[e-mail]]

Fix checked in.

Comment 4

[Eyal Rozenberg]

This triggered 
https://www.mozdev.org/bugs/show_bug.cgi?id=18352

Some extensions use toolbar_button_box in their overlay of the main toolbar.

Comment 5

[Robert Kaiser]

(In reply to comment #4)
> Some extensions use toolbar_button_box in their overlay of the main toolbar.

I expect that they need to change lots of stuff when we introduce toolbar customization, this is just one piece of that.

There is a reason why we bump the major version number to SeaMonkey 2.0, as lots of stuff is changing around in this release we are working around, and also many extension are expected to break. We won't be able to avoid that.

Comment 6

[Eyal Rozenberg]

Well, you could say, e.g. here in this bug, that this is part of a larger change and that you suggest extension developers wait with fixing breakages until sm has customizable toolbars.

Comment 7

[Robert Kaiser]

I thought that comment #0 and this being a blocker for bug 394288 makes it clear that this bug is a requirement for the larger work of customization.
And yes, it's probably best to wait with fixing breakages until customization is done, unless you can fix it now in a way that will still work with customization in place (don't ask me if that's possible or how, I don't know the code myself).