Closed Bug 407745 Opened 17 years ago Closed 17 years ago

Add lightning version in user-agent string

Categories

(Calendar :: Lightning Only, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: nomisvai, Assigned: Fallen)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9

Our caldav server has the ability to present data slightly differently depending on the CalDAV client being used(Mostly to work around client bugs), one issue we have is with the user-agent sent by thunerbird/lightning plug-in where the version of the lighning plug-in is not in the user-agent string, would it be possible to add it?

For Thunderbird w/ lightning 0.7 we get:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9

For sunbird 0.7 we get:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.8pre) Gecko/20071023 Sunbird/0.7



Reproducible: Always

Steps to Reproduce:
1.
2.
3.
This patch adds i.e Lightning/0.8pre to the user agent string. While I'm personally against each extension adding its string to the user agent, I think Lightning is prominent enough for it to make sense.
Assignee: nobody → philipp
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #292443 - Flags: review?(daniel.boelzle)
Assignee: philipp → nobody
Status: ASSIGNED → NEW
Component: Provider: CalDav → Lightning Only
OS: Windows XP → All
QA Contact: caldav-provider → lightning
Hardware: PC → All
Summary: Add lightning version in user-agent string sent to caldav servers → Add lightning version in user-agent string
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Comment on attachment 292443 [details] [diff] [review]
Add Lightning to the user agent string

r=dbo
Attachment #292443 - Flags: review?(daniel.boelzle) → review+
(In reply to comment #0)
> For sunbird 0.7 we get:
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.8pre)
> Gecko/20071023 Sunbird/0.7

Please keep in mind: In third party builds or nightly builds the UA contains "Calendar" instead of "Sunbird", e.g. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/20071209 Calendar/0.8pre.
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Verified in Lightning and Sunbird (build 20080114) -> task is fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.