407784 - "Copy Source Location" -> "Copy Download Link"

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Per bug 397655 comment #37.

Access key is still L

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 292463 [details] [diff] [review]
v1

s/cmd.copyLocation.label/cmd.copyDownloadLink.label/

r=sdwilsh

Comment 3

[Shawn Wilsher :sdwilsh]

Litmus tests may need to be updated.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> Litmus tests may need to be updated.

s/Copy Source Location/Copy Download Link -> https://litmus.mozilla.org/show_test.cgi?id=4636

in-litmus+

Comment 5

[Ed Lee :Mardak]

(In reply to comment #2)
> s/cmd.copyLocation.label/cmd.copyDownloadLink.label/
Urgh. Did you want that for only the label? And also the accesskey? Plus the menuitem? Not leaving out the cmd_copyLocation either. At least I'm renaming menuseparator_copy_location to be just plain menuseparator elsewhere..

http://mxr.mozilla.org/seamonkey/search?string=copyLocation&find=download

Comment 6

[Shawn Wilsher :sdwilsh]

The label is fine, really.  We have to change the string identifier so locales can pick it up.  I'm not too picky about the rest.  It'd be nice, but not terribly worried.

Comment 7

[Ed Lee :Mardak]

Attachment: v1.1

(In reply to comment #2)
> s/cmd.copyLocation.label/cmd.copyDownloadLink.label/
Fixed for both label and accesskey to remind localizers to fix up the access key if necessary. We just happen to not need to in english.

Comment 8

[Ed Lee :Mardak]

Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd,v  <--  downloads.dtd
new revision: 1.19; previous revision: 1.18
done
Checking in toolkit/mozapps/downloads/content/downloads.xul;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.xul,v  <--  downloads.xul
new revision: 1.36; previous revision: 1.35
done

Comment 9

[Sune Mølgaard]

Sorry to chime in only after the bug was "resolved", but a link may not necessarily be a download link in peoples opinion (yes, all links, except for js-ones trigger a download, but people don't view it that way).

Wouldn't "Copy Link URL" make a whole lot more sense?

Just my 2 cents...

Comment 10

[Shawn Wilsher :sdwilsh]

(In reply to comment #9)
> Sorry to chime in only after the bug was "resolved", but a link may not
> necessarily be a download link in peoples opinion (yes, all links, except for
> js-ones trigger a download, but people don't view it that way).
> 
> Wouldn't "Copy Link URL" make a whole lot more sense?
> 
> Just my 2 cents...
Possibly, but then most people don't understand what a URL is either...

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2007121604 Minefield/3.0b3pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2007121604 Minefield/3.0b3pre

and

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2007121605 Minefield/3.0b3pre