407841 - Empty pop-up when no Default Feed Viewer is selected is ugly

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Mark Mentovai]

When no Default Feed Viewer is configured, as in the case with a brand spankin' new account created in a virgin Leopard install, the Default Feed Viewer pop-up menu in the Navigation-I-mean-General preference pane shows up empty.  This looks pretty bad.  I think we should replace it with a localized string ("None" in English), but see bug 352451 comment 4.

Comment 1

[Mark Mentovai]

Attachment: Ugly

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I believe that's supposed to be "Select…", so perhaps this is fallout from bug 352451 comment 4?

Regardless, we should make it work and say something informative.

Comment 3

[Mark Mentovai]

Select… is the thing at the bottom of the list that lets you pick your own application.  That should never be the default value of the pop-up when you open the pref pane.

The empty entry is something else.

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/camino/src/browser/AppListMenuFactory.mm&rev=1.6&mark=160-162,170-174#151

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Markus, is this a bug you might be ready to tackle?

Comment 5

[Stuart Morgan]

Since this is trivial to fix, and we like to make mento happy, +ing for 1.6b3

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Cocoa copy-paste, for less ugly

So, Stuart Friday said I should be able to use my copy-paste skills to fix this bug, and, through the miracles of mxr and copy-paste in Cocoa, I present to you this patch.  It seems to work, and Camino doesn't appear to crash or growl at me as a result.

I'm not entirely thrilled with my localized string choice; maybe mento's "None" is really the way to go?

Comment 7

[Håkan Waara]

Nit: you should probably use nil instead of NULL if you want Cocoa bonus points.

Comment 8

[Håkan Waara]

Oh, other than that, r=me if you want it.

Comment 9

[Stuart Morgan]

(In reply to comment #7)
> Nit: you should probably use nil instead of NULL

nil would be incorrect; a selector is not an object pointer type.

Comment 10

[Stuart Morgan]

I tend to agree that "None" would be better

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: uses "None" (and no excess hunk)

Switches the string to "None" (and gets rid of the stray extra hunk that slipped in to the .strings from one of Stuart's patches).

Carrying forward the r=hwaara from comment 8, which I believe still stands.

Comment 12

[Stuart Morgan]

Comment on attachment 303969 [details] [diff] [review]
uses "None" (and no excess hunk)

>+"NoDefaultReader" = "None"

This line is missing the semicolon at the end, which will make the world a sad place.

sr=smorgan with that fixed.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on the trunk and MOZILLA_1_8_BRANCH with the semicolon to keep the world a happy place.  mento, please have a lovely (rest of) President's Day. :)