Closed
Bug 407933
Opened 17 years ago
Closed 16 years ago
[Task List] Initial width of the Done column too small - checkbox image is cropped
Categories
(Calendar :: Tasks, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: ssitter, Assigned: thetux.moz)
References
Details
Attachments
(2 files, 2 obsolete files)
2.67 KB,
patch
|
Fallen
:
review+
Fallen
:
ui-review+
|
Details | Diff | Splinter Review |
973 bytes,
image/png
|
chris.j.bugzilla
:
ui-review+
|
Details |
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.12pre) Gecko/2007121105 Calendar/0.8pre [Task List] Initial width of the Done column too small - checkbox image is cropped Steps to Reproduce: 1. Start Sunbird with clean profile 2. Create a task in the default calendar 3. Check the task list layout Actual Results: The right border of the checkbox image in the Done column is cropped, see screenshot. Expected Results: The checkbox image is fully visible. Increasing the width by one or two pixels make the full checkbox image visible. I think it also would make sense to apply a fixed width to this column instead of having a sizable column.
Comment 2•16 years ago
|
||
@Stefan: Thanks for finding my dup... Maybe you can set this one to CONFIRMED? @Philipp: I tried setting ' fixed="18" ' instead of ' width="18" ' without any effect... ' fixed="true" width="18" ' worked, but it resets the width for the first column, when I set it to both 'complete' and 'priority'.
Assignee | ||
Comment 3•16 years ago
|
||
I can confirm the bug. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Lightning/0.8pre (2008012320) Thunderbird/2.0.0.9 ID:2007103104
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → thetux.moz
Assignee | ||
Comment 4•16 years ago
|
||
If ui-review is needed, a screenshot is in the second attachment.
Attachment #306856 -
Flags: review?(philipp)
Assignee | ||
Comment 5•16 years ago
|
||
Assignee | ||
Comment 6•16 years ago
|
||
Checkbox image and priority image get protected from cropping. As requested the two columns get a fixed width, too.
Attachment #306856 -
Attachment is obsolete: true
Attachment #306857 -
Attachment is obsolete: true
Attachment #306881 -
Flags: ui-review?(christian.jansen)
Attachment #306881 -
Flags: review?
Attachment #306856 -
Flags: review?(philipp)
Assignee | ||
Comment 7•16 years ago
|
||
Comment 8•16 years ago
|
||
Comment on attachment 306882 [details]
New screenshot for UI-Review
looks good. thanks for the patch. R=christian
Attachment #306882 -
Flags: ui-review+
Comment 9•16 years ago
|
||
Comment on attachment 306881 [details] [diff] [review] Patch fixes cropped images and makes also the columns width fixed as requested >+ fixed="true" >+ fixed="true" I will fix tabs before checkin here. r=philipp, If possible I would like to have this tested on mac if possible, but since the change is minimal and expands rather than shrinks, I think it should do well.
Attachment #306881 -
Flags: review? → review+
Updated•16 years ago
|
Status: NEW → ASSIGNED
Flags: wanted-calendar0.8+
OS: Windows 2000 → All
Hardware: PC → All
Updated•16 years ago
|
Attachment #306881 -
Flags: ui-review?(christian.jansen) → ui-review+
Comment 10•16 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Comment 11•16 years ago
|
||
Checked in lightning build 2008030318 and sunbird 20080303 -> task is fixed and verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•