Closed Bug 407951 Opened 12 years ago Closed 12 years ago

don't reset textContent in _setUpDescription() if it hasn't changed

Categories

(Firefox :: Address Bar, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3 beta3

People

(Reporter: moco, Assigned: moco)

References

Details

(Keywords: perf)

Attachments

(1 file)

don't reset textContent in _setUpDescription() if it hasn't changed

a potential perf win suggestion from vlad.

if we have:

<description>foo<label value="bar"/>cheese</description>

And you continue to type barcheese, the "foo" textContent will not change.

Vlad believes that it would be faster to check the textContent and not change it.

This should also pay off when we invalidate() as more results come in and the users typed text hasn't changed.

We should be able to verify this using vlad's foo.xul test case (I'll attach it.)

(soon, the label will be a html:span, but doesn't matter for this bug...)
Depends on: 402118
Keywords: perf
OS: Mac OS X → All
Hardware: PC → All
Target Milestone: --- → Firefox 3 M11
Assignee: nobody → sspitzer
fixed as part of bug #402118
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.