407982 - More events should walk the Gdk tree instead of being dropped

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Michael Ventnor]

Attachment: Patch

We fixed the problem where you couldn't scroll while the cursor is over a plugin in bug 386687. More of these events should take the same approach; specifically, mouse events. This is especially problematic when autoscrolling because the speed/direction may not change (mousemove) or you can't cancel it with a click (mousedown/mouseup). This may (I don't know for certain) also allow Linux to receive mouse events on the DOM from plugin windows.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+        if (aEvent->window == mDrawingarea->inner_window) {
+            event.refPoint.x = nscoord(aEvent->x);
+            event.refPoint.y = nscoord(aEvent->y);
+        } else {
+            nsRect windowRect;
+            ScreenToWidget(nsRect(nscoord(aEvent->x_root), nscoord(aEvent->y_root), 1, 1), windowRect);
+
+            event.refPoint.x = windowRect.x;
+            event.refPoint.y = windowRect.y;
+        }

This code should be factored out and shared.

+    nsRefPtr<nsWindow> window;
+    GdkWindow *gdkWindow = event->window;
+    while (!(window = get_window_for_gdk_window(gdkWindow))) {
+        // See scroll_event_cb. We need this to get events even when cursor is over plugins.
+        gdkWindow = gdk_window_get_parent(gdkWindow);
+        if (!gdkWindow)
+            return FALSE;
+    }

This loop should be factored out and shared too. Something like
already_AddRefed<nsWindow> GetEventTargetWindow(GdkEvent*) or something.

Comment 2

[Michael Ventnor]

Attachment: Patch 2

The first part can't be factored out because GDK event structures are evil, but the second part can be happily refactored.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+static nsWindow* get_first_nswindow_for_gdkwindow (GdkWindow *aGdkWindow);

Call this GetFirstNSWindowForGDKWindow

+    nsRefPtr<nsWindow> window = get_first_nswindow_for_gdkwindow(gdkWindow);

'window' should just be an nsWindow* (4 occurrences)

Comment 4

[Michael Ventnor]

Attachment: Patch 2.1

Comment 5

[Michael Ventnor]

Attachment: Patch 2.2

Forgot about unnecessary local variable during refactoring.

Comment 6

[Reed Loden [:reed]]

Checking in widget/src/gtk2/nsCommonWidget.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsCommonWidget.cpp,v  <--  nsCommonWidget.cpp
new revision: 1.34; previous revision: 1.33
done
Checking in widget/src/gtk2/nsCommonWidget.h;
/cvsroot/mozilla/widget/src/gtk2/nsCommonWidget.h,v  <--  nsCommonWidget.h
new revision: 1.26; previous revision: 1.25
done
Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.242; previous revision: 1.241
done
Checking in widget/src/gtk2/nsWindow.h;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.h,v  <--  nsWindow.h
new revision: 1.81; previous revision: 1.80
done