Closed
Bug 407985
Opened 17 years ago
Closed 17 years ago
autocomplete-search-engine-img is 18px high (Google icon etc)
Categories
(SeaMonkey :: Autocomplete, defect)
SeaMonkey
Autocomplete
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: stefanh, Assigned: neil)
Details
Attachments
(2 files)
|
2.39 KB,
image/png
|
Details | |
|
477 bytes,
patch
|
stefanh
:
review+
|
Details | Diff | Splinter Review |
Original icon vs icon in url bar search box
The icon should be 16px high, but according to DOMi the height is 18px. So the icon has a "stretched" look.
|
Assignee | |
Comment 1•17 years ago
|
||
OK, so what I think is going on here applies to anyone whose default font is anything other than 13 pixels tall. It so happens that, at least on Windows, the default margins on a label add (in total) another 3px of height making 16 pixels which is of course the height of the search icon.
|
Reporter | |
Comment 2•17 years ago
|
||
Comment on attachment 292761 [details] [diff] [review] Proposed patch You're right, 15px height + 3px vertical margin and 'stretch', doesn't do well to a 16x16 icon. Thanks.
Attachment #292761 -
Flags: review?(stefanh) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•17 years ago
|
OS: Mac OS X → All
Hardware: PC → All
Target Milestone: --- → seamonkey2.0alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•