407988 - Windows Firefox 3 Beta 2 Builds broken !

Status: VERIFIED FIXED

(Release Engineering :: General, defect, P1)

Description

[Carsten Book [:Tomcat]]

The Windows unsigned builds are broken. After install i get a sidebyside error;. Xp and Vista are affected;

Vista Event Log output

   1.
      Activation context generation failed for "C:\Program Files\Mozilla Firefox 3 Beta 2\firefox.exe". Dependent Assembly Microsoft.VC80.CRT,processorArchitecture="x86",publicKeyToken="1fc8b3b9a1e18e3b",type="win32",version="8.0.50727.762" could not be found. Please use sxstrace.exe for detailed diagnosis

      Activation context generation failed for "C:\Program Files\Mozilla Firefox 3 Beta 2\AccessibleMarshal.dll". Dependent Assembly Microsoft.VC80.CRT,processorArchitecture="x86",publicKeyToken="1fc8b3b9a1e18e3b",type="win32",version="8.0.50727.762" could not be found. Please use sxstrace.exe for detailed diagnosis. 

See also http://pastebin.mozilla.org/262786

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Seems this is caused by a missing env.variable "WIN32_REDIST_DIR". Both our trunk staging and trunk production systems have the same missing variable problem. 

Sadly it only shows up as a problem when the machine has no VC installed. All of our win32 build machines do have VC installed, so we never caught this.

Comment 2

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

This is only a problem on win32. Existing linux & mac builds are confirmed to be ok.

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: [backed out] set WIN32_REDIST_DIR in mozconfig

This should be set in the mozconfig, not in the .bash_profile on the machine.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 292700 [details] [diff] [review]
[backed out] set WIN32_REDIST_DIR in mozconfig

looks good to me, r=mconnor

Comment 5

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

we're restarting win32 builds with this patch landed; keeping bug open until we confirm problem is fixed. 

Comment 6

[Robert Helmer [:rhelmer]]

Comment on attachment 292700 [details] [diff] [review]
[backed out] set WIN32_REDIST_DIR in mozconfig

sorry for the noise; doesn't seem to work.

Benjamin, please show me what I'm missing here :) There's no configure flag so I can't use ac_add_options for this, right?

I'm testing setting it as an environment variable from tinder-config.pl instead.

Comment 7

[Benjamin Smedberg]

Comment on attachment 292700 [details] [diff] [review]
[backed out] set WIN32_REDIST_DIR in mozconfig

mk_add_options is wrong... you want to set the variable as a shell variable plainly without mk_add_options or ac_add_options:

WIN32_REDIST_DIR="/d/msvs8/VC/redist/x86/Microsoft.VC80.CRT"

Comment 8

[Robert Helmer [:rhelmer]]

Attachment: [checked in] set WIN32_REDIST_DIR as env var

Comment 9

[Robert Helmer [:rhelmer]]

This does work, thanks.

Comment 10

[Robert Helmer [:rhelmer]]

Comment on attachment 292712 [details] [diff] [review]
[checked in] set WIN32_REDIST_DIR as env var

Checking in mozconfig;
/cvsroot/mozilla/tools/tinderbox-configs/firefox/win32/mozconfig,v  <--  mozconfig
new revision: 1.3.2.7; previous revision: 1.3.2.6

Comment 11

[Robert Helmer [:rhelmer]]

en-US builds are up in the candidates area. Build ID of corrected builds is 2007121120.

I see the files in the zip at least:
   479232  12-11-07 20:48   firefox/msvcm80.dll
   548864  12-11-07 20:48   firefox/msvcp80.dll
   626688  12-11-07 20:48   firefox/msvcr80.dll

Comment 12

[Carsten Book [:Tomcat]]

verified fixed with 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2) Gecko/2007121120
Firefox/3.0b2 and Mozilla/5.0 and (Windows; U; Windows NT 5.1; en-US; 
rv:1.9b2) Gecko/2007121120

installing and running is fine now, rhelmer, joduinn thanks !