Closed
Bug 407988
Opened 17 years ago
Closed 17 years ago
Windows Firefox 3 Beta 2 Builds broken !
Categories
(Release Engineering :: General, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: cbook, Assigned: rhelmer)
References
Details
Attachments
(1 file, 1 obsolete file)
858 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
The Windows unsigned builds are broken. After install i get a sidebyside error;. Xp and Vista are affected; Vista Event Log output 1. Activation context generation failed for "C:\Program Files\Mozilla Firefox 3 Beta 2\firefox.exe". Dependent Assembly Microsoft.VC80.CRT,processorArchitecture="x86",publicKeyToken="1fc8b3b9a1e18e3b",type="win32",version="8.0.50727.762" could not be found. Please use sxstrace.exe for detailed diagnosis Activation context generation failed for "C:\Program Files\Mozilla Firefox 3 Beta 2\AccessibleMarshal.dll". Dependent Assembly Microsoft.VC80.CRT,processorArchitecture="x86",publicKeyToken="1fc8b3b9a1e18e3b",type="win32",version="8.0.50727.762" could not be found. Please use sxstrace.exe for detailed diagnosis. See also http://pastebin.mozilla.org/262786
Updated•17 years ago
|
Priority: -- → P1
Comment 1•17 years ago
|
||
Seems this is caused by a missing env.variable "WIN32_REDIST_DIR". Both our trunk staging and trunk production systems have the same missing variable problem. Sadly it only shows up as a problem when the machine has no VC installed. All of our win32 build machines do have VC installed, so we never caught this.
Comment 2•17 years ago
|
||
This is only a problem on win32. Existing linux & mac builds are confirmed to be ok.
OS: Mac OS X → Windows Server 2003
Assignee | ||
Comment 3•17 years ago
|
||
This should be set in the mozconfig, not in the .bash_profile on the machine.
Assignee | ||
Updated•17 years ago
|
Attachment #292700 -
Flags: review?(benjamin) → review?(mconnor)
Comment 4•17 years ago
|
||
Comment on attachment 292700 [details] [diff] [review] [backed out] set WIN32_REDIST_DIR in mozconfig looks good to me, r=mconnor
Attachment #292700 -
Flags: review?(mconnor) → review+
Comment 5•17 years ago
|
||
we're restarting win32 builds with this patch landed; keeping bug open until we confirm problem is fixed.
Assignee | ||
Updated•17 years ago
|
Attachment #292700 -
Attachment description: set WIN32_REDIST_DIR in mozconfig → [backed out] set WIN32_REDIST_DIR in mozconfig
Attachment #292700 -
Attachment is obsolete: true
Assignee | ||
Comment 6•17 years ago
|
||
Comment on attachment 292700 [details] [diff] [review] [backed out] set WIN32_REDIST_DIR in mozconfig sorry for the noise; doesn't seem to work. Benjamin, please show me what I'm missing here :) There's no configure flag so I can't use ac_add_options for this, right? I'm testing setting it as an environment variable from tinder-config.pl instead.
Comment 7•17 years ago
|
||
Comment on attachment 292700 [details] [diff] [review] [backed out] set WIN32_REDIST_DIR in mozconfig mk_add_options is wrong... you want to set the variable as a shell variable plainly without mk_add_options or ac_add_options: WIN32_REDIST_DIR="/d/msvs8/VC/redist/x86/Microsoft.VC80.CRT"
Attachment #292700 -
Flags: review+ → review-
Assignee | ||
Comment 8•17 years ago
|
||
Attachment #292712 -
Flags: review?(benjamin)
Assignee | ||
Comment 9•17 years ago
|
||
This does work, thanks.
Updated•17 years ago
|
Attachment #292712 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 10•17 years ago
|
||
Comment on attachment 292712 [details] [diff] [review] [checked in] set WIN32_REDIST_DIR as env var Checking in mozconfig; /cvsroot/mozilla/tools/tinderbox-configs/firefox/win32/mozconfig,v <-- mozconfig new revision: 1.3.2.7; previous revision: 1.3.2.6
Attachment #292712 -
Attachment description: set WIN32_REDIST_DIR as env var → [checked in] set WIN32_REDIST_DIR as env var
Assignee | ||
Comment 11•17 years ago
|
||
en-US builds are up in the candidates area. Build ID of corrected builds is 2007121120. I see the files in the zip at least: 479232 12-11-07 20:48 firefox/msvcm80.dll 548864 12-11-07 20:48 firefox/msvcp80.dll 626688 12-11-07 20:48 firefox/msvcr80.dll
Reporter | ||
Comment 12•17 years ago
|
||
verified fixed with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2) Gecko/2007121120 Firefox/3.0b2 and Mozilla/5.0 and (Windows; U; Windows NT 5.1; en-US; rv:1.9b2) Gecko/2007121120 installing and running is fine now, rhelmer, joduinn thanks !
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•