Provide short-hand includetype=unstable .pc files for libxul and libxul-embedding

RESOLVED FIXED in mozilla1.9beta3

Status

Product:
Toolkit Graveyard
Component:
XULRunner
--
enhancement
RESOLVED FIXED
Reported:
10 years ago
Modified:
2 years ago

People

(Reporter: Alexander Sack, Assigned: Alexander Sack)

Tracking

Version:
Trunk
Target:
mozilla1.9beta3
x86
Linux

Details

Attachments

(1 attachment, 2 obsolete attachments)

removed copy/paste comment
2.18 KB, patch
Benjamin Smedberg
: review+
damons
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

•
10 years ago 
Please provide short-hand .pc config files libxul-unstable.pc and libxul-embedding-unstable.pc.

Reason: While --define-variable=includetype=unstable works well from the command line it doesn't go together well with the autoconf pkg.m4 (which doesn't support any parameters). nor does it allow libs to refer to the unstable API in the |Requires| field, like:

 Requires: libxul-unstable

While I see that its discouraged to use unstable, its commonly used by gecko embedders in the free software community (especially since gtkmozembed is in unstable). Providing libxul-embedding-unstable.pc and libxul-unstable.pc would ease migrating those apps to xulrunner 1.9 a lot.
(Assignee)

Comment 1

•
10 years ago 
Created attachment 292764 [details] [diff] [review]
provide unstable .pc files
Assignee: nobody → asac
Status: NEW → ASSIGNED
Attachment #292764 - Flags: review?(benjamin)
(Assignee)

Comment 2

•
10 years ago 
Created attachment 292766 [details] [diff] [review]
oops ... here right one
Attachment #292764 - Attachment is obsolete: true
Attachment #292766 - Flags: review?(benjamin)
Attachment #292764 - Flags: review?(benjamin)

Comment 3

•
10 years ago 
Comment on attachment 292766 [details] [diff] [review]
oops ... here right one

This is ok, except you copy-pasted the comment from the other .pc file which no longer applies.
Attachment #292766 - Flags: review?(benjamin) → review-
 (Assignee)

Comment 4

•
10 years ago 
Created attachment 295209 [details] [diff] [review]
removed copy/paste comment
Attachment #292766 - Attachment is obsolete: true
Attachment #295209 - Flags: review?(benjamin)
Assignee: asac → nobody
Status: ASSIGNED → NEW
Component: Build Config → XULRunner
QA Contact: build-config → xulrunner
Version: unspecified → Trunk
Assignee: nobody → asac
Status: NEW → ASSIGNED

Updated

•
10 years ago
Attachment #295209 - Flags: review?(benjamin) → review+
 (Assignee)

Updated

•
10 years ago
Attachment #295209 - Flags: approval1.9?

Updated

•
10 years ago
Attachment #295209 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed

Comment 5

•
10 years ago 
Checking in xulrunner/installer/Makefile.in;
/cvsroot/mozilla/xulrunner/installer/Makefile.in,v  <--  Makefile.in
new revision: 1.11; previous revision: 1.10
done
RCS file: /cvsroot/mozilla/xulrunner/installer/libxul-embedding-unstable.pc.in,v
done
Checking in xulrunner/installer/libxul-embedding-unstable.pc.in;
/cvsroot/mozilla/xulrunner/installer/libxul-embedding-unstable.pc.in,v  <--  libxul-embedding-unstable.pc.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/xulrunner/installer/libxul-unstable.pc.in,v
done
Checking in xulrunner/installer/libxul-unstable.pc.in;
/cvsroot/mozilla/xulrunner/installer/libxul-unstable.pc.in,v  <--  libxul-unstable.pc.in
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.