Closed Bug 408062 Opened 16 years ago Closed 16 years ago

Provide short-hand includetype=unstable .pc files for libxul and libxul-embedding

Categories

(Toolkit Graveyard :: XULRunner, enhancement)

Product:
Toolkit Graveyard
Component:
XULRunner
Platform:
x86
Linux
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta3

People

(Reporter: asac, Assigned: asac)

Details

Attachments

(1 file, 2 obsolete files)

removed copy/paste comment
2.18 KB, patch
benjamin
: review+
damons
: approval1.9+
Details | Diff | Splinter Review 
Please provide short-hand .pc config files libxul-unstable.pc and libxul-embedding-unstable.pc.

Reason: While --define-variable=includetype=unstable works well from the command line it doesn't go together well with the autoconf pkg.m4 (which doesn't support any parameters). nor does it allow libs to refer to the unstable API in the |Requires| field, like:

 Requires: libxul-unstable

While I see that its discouraged to use unstable, its commonly used by gecko embedders in the free software community (especially since gtkmozembed is in unstable). Providing libxul-embedding-unstable.pc and libxul-unstable.pc would ease migrating those apps to xulrunner 1.9 a lot.
Attached patch provide unstable .pc files (obsolete) — — Splinter Review 
Assignee: nobody → asac
Status: NEW → ASSIGNED

        Attachment #292764 -
        Flags: review?(benjamin)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        oops ... here right one (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #292764 -
        Attachment is obsolete: true

        Attachment #292766 -
        Flags: review?(benjamin)

        Attachment #292764 -
        Flags: review?(benjamin)

    
    

    
  
Comment on attachment 292766 [details] [diff] [review]
oops ... here right one

This is ok, except you copy-pasted the comment from the other .pc file which no longer applies.

        Attachment #292766 -
        Flags: review?(benjamin) → review-

    
    

    
  


  

        Attachment #292766 -
        Attachment is obsolete: true

        Attachment #295209 -
        Flags: review?(benjamin)

    
  
Assignee: asac → nobody
Status: ASSIGNED → NEW
Component: Build Config → XULRunner
QA Contact: build-config → xulrunner
Version: unspecified → Trunk

    
  
Assignee: nobody → asac

    
  
Status: NEW → ASSIGNED

    
  

        Attachment #295209 -
        Flags: review?(benjamin) → review+

    
  

        Attachment #295209 -
        Flags: approval1.9?

        Attachment #295209 -
        Flags: approval1.9? → approval1.9+

    
  
Keywords: checkin-needed

    
    

    
  
Checking in xulrunner/installer/Makefile.in;
/cvsroot/mozilla/xulrunner/installer/Makefile.in,v  <--  Makefile.in
new revision: 1.11; previous revision: 1.10
done
RCS file: /cvsroot/mozilla/xulrunner/installer/libxul-embedding-unstable.pc.in,v
done
Checking in xulrunner/installer/libxul-embedding-unstable.pc.in;
/cvsroot/mozilla/xulrunner/installer/libxul-embedding-unstable.pc.in,v  <--  libxul-embedding-unstable.pc.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/xulrunner/installer/libxul-unstable.pc.in,v
done
Checking in xulrunner/installer/libxul-unstable.pc.in;
/cvsroot/mozilla/xulrunner/installer/libxul-unstable.pc.in,v  <--  libxul-unstable.pc.in
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.