408109 - nsProfileCollector::LogBookmarkLocation does not count bookmarks

Status: RESOLVED FIXED

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Description

[Alex Polvi]

LogBookmarkLocation is supposed to count the number of bookmarks by type. It is called by the profile collector, and the expected output is something like this:

<bookmarks>
  <bookmarklocation foldercount="4" itemcount="6" separatorcount="2"
livemarkcount="1" name="full-tree"/>
  <bookmarklocation foldercount="2" itemcount="1" separatorcount="2"
livemarkcount="0" name="root"/>
  <bookmarklocation foldercount="0" itemcount="1" separatorcount="0"
livemarkcount="1" name="toolbar"/>
</bookmarks>

That data comes from bug 399869, so it was working at some point.

However, it is currently reporting a 0 itemcount for all profiles that are sending data. For example:

<bookmarks>
  <bookmarklocation foldercount="0" itemcount="0" separatorcount="0" livemarkcount="0" name="full-tree"/>
  <bookmarklocation foldercount="0" itemcount="0" separatorcount="0" livemarkcount="0" name="root"/>
  <bookmarklocation foldercount="0" itemcount="0" separatorcount="0" livemarkcount="0" name="toolbar"/>
</bookmarks>

I do not think this is related to bug 356606... but it is possible I missed the connection in the collector.

Comment 1

[Pete Collins (MDG)]

Attachment: comment out options setting seems to fix bookmarks counter

Ok, I have a patch for this.

Here is my bookmarks data w/ the patch

<bookmarks>
<bookmarklocation foldercount="6" itemcount="6" separatorcount="2" livemarkcount="1" name="full-tree"/>
<bookmarklocation foldercount="1" itemcount="1" separatorcount="1" livemarkcount="0" name="root"/>
<bookmarklocation foldercount="1" itemcount="1" separatorcount="0" livemarkcount="1" name="toolbar"/>
</bookmarks>

Comment 2

[Pete Collins (MDG)]

Jan can you review this one please ...

Comment 3

[Jan Varga [:janv]]

See these comments:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/browser/components/places/content&command=DIFF_FRAMESET&file=tree.xml&rev2=1.50&rev1=1.49

I wonder why it worked before. If the output you get is correct then r=varga

Comment 4

[Pete Collins (MDG)]

> If the output you get is correct then r=varga

Yea, in fact as I added an additional bm to my toolbar, I can see the itemcount increment to reflect the change ...

Comment 5

[Pete Collins (MDG)]

patch checked in