Closed
Bug 408216
Opened 17 years ago
Closed 17 years ago
crash after changing layout.css.dpi [@ nsIPresShell::GetViewManager]
Categories
(Core :: Layout, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: ajschult784, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(2 files)
|
5.39 KB,
text/plain
|
Details | |
|
2.26 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
With current trunk, I crash if I change layout.css.dpi via about:config. This regressed between 2007-12-11-08-trunk and 2007-12-12-10-trunk, indicating bug 403067. Stacktrace is attached.
Flags: blocking1.9?
|
Reporter | |
Updated•17 years ago
|
OS: Other → Linux
Hardware: Other → PC
|
|
Reporter | |
Updated•17 years ago
|
Severity: normal → critical
|
||
Updated•17 years ago
|
Summary: crash after changing layout.css.dpi → crash after changing layout.css.dpi [@ nsIPresShell::GetViewManager]
|
Assignee | |
Comment 1•17 years ago
|
||
The GetViewManager() call used to be protected by the 'mShell' null-check.
Attachment #293260 -
Flags: superreview?(roc)
Attachment #293260 -
Flags: review?(roc)
Flags: blocking1.9? → blocking1.9+
Priority: -- → P1
Nope, CheckDPIChange has side effects that affect the results of those expressions, so they have to run before CheckDPIChange.
|
|
Assignee | |
Comment 3•17 years ago
|
||
Ok, I did save AppUnitsPerDevPixel... I couldn't see any other side effects.
Comment on attachment 293260 [details] [diff] [review] Like so? oops yeah you're right
Attachment #293260 -
Flags: superreview?(roc)
Attachment #293260 -
Flags: superreview+
Attachment #293260 -
Flags: review?(roc)
Attachment #293260 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Assignee: roc → mats.palmgren
|
|
Assignee | |
Comment 5•17 years ago
|
||
mozilla/layout/base/nsPresContext.cpp 3.339 -> FIXED
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
|
||
Updated•13 years ago
|
Crash Signature: [@ nsIPresShell::GetViewManager]
You need to log in
before you can comment on or make changes to this bug.
Description
•