Reading backup preferences fails [Error: backupBranch is not defined]

VERIFIED FIXED in 0.9

Status

Calendar
Provider: ICS/WebDAV
--
minor
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Stefan Sitter, Assigned: dbo)

Tracking

unspecified
Bug Flags:
wanted-calendar0.9 +

Details

(URL)

Attachments

(1 attachment)

fix
1.68 KB, patch
Michiel van Leeuwen (email: mvl+moz@)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.12pre) Gecko/20071213 Calendar/0.8pre

The following error was shown in Venkman during event creation/editing:

    Error "backupBranch is not defined" [x-] in file 
    "file:///D:/sunbird/js/calICSCalendar.js", line 625.

backupBranch is accessed in function getIntPrefSafe() but is never created:
http://lxr.mozilla.org/seamonkey/source/calendar/providers/ics/calICSCalendar.js#625

This means the backup code will always fallback to the default values passed in.

Not sure if this is on purpose or not. The first iteration of the patch in Bug 307033 defined backupBranch, the second and third iteration did not.
Flags: wanted-calendar0.9?
OS: Windows 2000 → All
Hardware: PC → All
Version: Mozilla 1.8 Branch → unspecified
(Assignee)

Updated

10 years ago
Flags: wanted-calendar0.9? → wanted-calendar0.9+
(Assignee)

Comment 1

10 years ago
Created attachment 323387 [details] [diff] [review]
fix
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #323387 - Flags: review?(mvl)
Comment on attachment 323387 [details] [diff] [review]
fix

r=mvl
Attachment #323387 - Flags: review?(mvl) → review+
(Assignee)

Comment 3

10 years ago
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9

Comment 4

9 years ago
Checked via mxr.mozilla.org -> VERIFIED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.