Use a constant-size buffer in BMP decoder to reduce fragmentation

VERIFIED FIXED in mozilla1.9beta3

Status

()

Core
ImageLib
P1
normal
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

({fixed1.8.0.15, verified1.8.1.12})

Trunk
mozilla1.9beta3
fixed1.8.0.15, verified1.8.1.12
Points:
---
Bug Flags:
blocking1.9 +
blocking1.8.1.12 +
wanted1.8.1.x +
blocking1.8.0.next +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Per bug 408076.
Created attachment 293003 [details] [diff] [review]
patch

like so!
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #293003 - Flags: superreview?(pavlov)
Attachment #293003 - Flags: review?(dveditz)
Comment on attachment 293003 [details] [diff] [review]
patch

r/sr=dveditz
Attachment #293003 - Flags: superreview?(pavlov)
Attachment #293003 - Flags: superreview+
Attachment #293003 - Flags: review?(dveditz)
Attachment #293003 - Flags: review+

Updated

10 years ago
Flags: blocking1.9+
mozilla/modules/libpr0n/decoders/bmp/nsBMPDecoder.cpp 	1.38
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Priority: -- → P1
Resolution: --- → FIXED
Comment on attachment 293003 [details] [diff] [review]
patch

Would be nice to get this into 2.0.0.12 as well.
Attachment #293003 - Flags: approval1.8.1.12?
Flags: blocking1.8.1.12+
Comment on attachment 293003 [details] [diff] [review]
patch

approved for 1.8.1.12, a=dveditz for release-drivers
Attachment #293003 - Flags: approval1.8.1.12? → approval1.8.1.12+
mozilla/modules/libpr0n/decoders/bmp/nsBMPDecoder.cpp 	1.29.4.1
Keywords: fixed1.8.1.12
Flags: wanted1.8.1.x+
Is this one of these magical fixes where one of you just tells us in QA that it is in or is the verification in bug 408076 also verification of this?
The verification of bug 408076 verifies this bug.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.12 → verified1.8.1.12
Flags: blocking1.8.0.15?

Comment 9

9 years ago
distro patch: blocks 1.8.0.15
Flags: blocking1.8.0.15? → blocking1.8.0.15+

Comment 10

9 years ago
Comment on attachment 293003 [details] [diff] [review]
patch

a=asac for 1.8.0.15 

approving unmodified distro patch.
Attachment #293003 - Flags: approval1.8.0.15+
I landed the patch in bug 408076 on the 1.8.0 branch.
Keywords: fixed1.8.0.15
mozilla/modules/libpr0n/decoders/bmp/nsBMPDecoder.cpp 	1.29.12.1
You need to log in before you can comment on or make changes to this bug.