408322 - right click, bookmark this link doesn't bookmark the link

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

right click, bookmark this link doesn't bookmark the link

Comment 1

[(not reading, please use [e-mail] instead)]

in my console, I'm seeing:

Error: PlacesUtils.ptm.commitTransaction is not a function
Source File: chrome://browser/content/browser.js
Line: 5396

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

do de do

Comment 3

[Phil Ringnalda (:philor)]

Interesting that it's been broken for going on 11 days without anyone noticing, or hitting it in a Litmus test. I sort of vaguely thought it was a smoketest, back before Places Mark I left it broken for several months.

Comment 4

[Dietrich Ayala (:dietrich)]

the litmus feedback loop is too slow. we should be taking advantage of the browser mochitests for these basic cases.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 293090 [details] [diff] [review]
Fix v.1

r=sspitzer, thanks Phil.

Comment 6

[(not reading, please use [e-mail] instead)]

let's heed dietrich's advice and work on a test.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 293090 [details] [diff] [review]
Fix v.1

a=beltzner

Comment 8

[(not reading, please use [e-mail] instead)]

fixed, thanks Phil. 

Checking in browser/base/content/browser-places.js;
/cvsroot/mozilla/browser/base/content/browser-places.js,v  <--  browser-places.j
s
new revision: 1.73; previous revision: 1.72
done

Comment 9

[(not reading, please use [e-mail] instead)]

whoops, Phil has cvs access, so I should have let him check his own patch in.   

(Sorry Phil, won't happen again)

Comment 11

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2007122704 Minefield/3.0b3pre.  

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv