408359 - Password Manager dialog's Show/Hide Passwords button does not have an access key

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement)

Description

[(no longer active)]

Attachment: Patch (v1)

The Show/Hide Passwords button in the Password Manager dialog does not have any access keys.  The attached patch fixes this problem.

Comment 1

[Asaf Romano (gone)]

Comment on attachment 293129 [details] [diff] [review]
Patch (v1)

r=mano

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 293129 [details] [diff] [review]
Patch (v1)

a=beltzner

Comment 3

[Justin Dolske [:Dolske]]

Checking in toolkit/components/passwordmgr/content/passwordManager.js;
/cvsroot/mozilla/toolkit/components/passwordmgr/content/passwordManager.js,v  <--  passwordManager.js
new revision: 1.20; previous revision: 1.19
done
Checking in toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties,v  <--  passwordmgr.properties
new revision: 1.13; previous revision: 1.12
done

Comment 4

[(no longer active)]

I'm slapping myself in the face.  The access key for Show Passwords (S) clashes with that of the search box...  :(

I'll be posting a patch shortly.

Comment 5

[(no longer active)]

Attachment: Fix the access key clash with the search box

Fix for the problem explained in comment 4.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 293420 [details] [diff] [review]
Fix the access key clash with the search box

I should have caught this :-/ Thanks for the quick fix.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 293420 [details] [diff] [review]
Fix the access key clash with the search box

a=mconnor on behalf of drivers

Comment 8

[Justin Dolske [:Dolske]]

Checked in.

Checking in toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/passwordmgr/passwordmgr.properties,v  <--  passwordmgr.properties
new revision: 1.14; previous revision: 1.13