408513 - Misleading information in "Close Firefox" message box.

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Biju]

Attachment: CloseFirefox.png

Sub: Misleading information in "Close Firefox" message box when your run Firefox on two instance of same user account on Terminal Server.
(also may be on Citrix too)

Current Message:-
   Firefox is already running, but is not responding.
   To open a new window, you must first close the existing Firefox process, 
   or restart your system.

Expected Message:-
   Firefox is already running, but is not responding.
   To open a new window, you must first close the existing Firefox process, 
   or restart your system.
     <small print>
         An advanced user may also choose to run Firefox using another profile.
     </small print>
  

My friend mention about the issue they faced while testing their website on Firfox. He cant make Firefox run more than one instant of same users terminal server account.

I searched Bugzilla and found the same issue reported early in Bug 308162 
After reading it and testing on Terminal Severer, I found Firefox is capable of running on multiple instance but just need a new profile.


Steps:-
1. Using "Remote Desktop Connection" logon to Windows Terminal Server. 
2. Start Firefox
3. Run another instance of "Remote Desktop Connection" and logon to same "Terminal Server" with same windows userid as used in step 1.
4. Try to start Firefox
5. user get "CloseFirefox.png"
6. Start Firefox with profile manager option, i.e. "Firefox.exe -p"
7. User get "Profile Manager" screen
8. Create a new profile (or choose another)
9. Select new the profile and click "Start Firefox" (or Minefield in my case)
10. user see new instance of Firefox without any problem.

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9b3pre) Gecko/2007121305 Minefield/3.0b3pre

Comment 3

[Mike Kaply [:mkaply]]

We should just add additional text to this dialog that says "You can also use a different profile" or something like that.

Comment 4

[ma18btech11011]

Can I be assigned this bug?

Comment 5

[Shrey Gupta]

Hello,
I would like to contribute to this bug. It is my first bug so please guide me the code of this issue.
Thank You

Comment 6

[Mike Kaply [:mkaply]]

The message is here:

https://searchfox.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/profile/profileSelection.properties#10

the message is referenced here.

https://searchfox.org/mozilla-central/source/toolkit/xre/nsAppRunner.cpp#1735

You would need to create a new string with additional text. See: https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 7

[Helen]

Hello,
I'm new to the codebase and I was able to reproduce this issue with my current environment, I would like to give this bug a try.

Comment 8

[Jayati Shrivastava]

Hi, if no one is working, then may I work on this?

Comment 9

[Mike Kaply [:mkaply]]

Yes, feel free.

Comment 10

[Jayati Shrivastava]

Attachment: Bug 408513 - Fix message in "Close Firefox" message box. r=mkaply

Comment 11

[Mike Kaply [:mkaply]]

Meridel:

Need UX to approve this small change. When you start Firefox and it's already running, we want to add some additional guidance.

This: Firefox is already running, but is not responding. To open a new window, you must first close the existing Firefox process, or restart your system.

To this: Firefox is already running, but is not responding. To open a new window, you must first close the existing Firefox process, or restart your system. You can also use a different profile to open a new window.

(Just adding the second sentence. - You can also use a different profile to open a new window.)

Thank you in advance for the input.

Comment 12

[Meridel [:meridel]]

Apologies for the delay!

Comments
-I am not able to reproduce this message on my own, but it is my understanding that the user cannot actually 'close' Firefox. They must 'end' the process via the task manager. So the header and body language referring to "closing" Firefox is not accurate.
-While the primary recipients of this message will be power users, it still may be helpful to identify where they can end the current process. Thus the inclusion of "Task Manager."
-User's goal is to use Firefox. We can tighten up the three options that lead to meeting this goal by using "To use Firefox..." followed by three options, instead of "To open a new window" followed by two sentences.
-I've proposed a new header that I think better captures the overarching message and doesn't just point to one solution ("close" Firefox...noting that, per point above, 'closing' is not possible)

Proposed Copy
Header: Firefox not responding
Body: Firefox is already running, but is not responding. To use Firefox, you must end the existing process in the Task Manager, restart your system, or use a different profile.

Comment 13

[Mike Kaply [:mkaply]]

Actually, many times you can close Firefox (It's just a second copy open), and Task Manager is very Windows specific.

Any other cleanup we can do?

Comment 14

[Meridel [:meridel]]

Ah, I thought this was message WAS Windows specific. Thank you for the context! Proposed copy below.

Header: Close Firefox
Body: Firefox is already running, but is not responding. To use Firefox, you must first close the existing Firefox process, restart your device, or use a different profile.

Comment 15

[Mike Kaply [:mkaply]]

Jayati: sorry for the back and forth on this. If you can update the string to Meridel's suggestion, we're good to go.

Comment 16

[Jayati Shrivastava]

Patch Updated :)

Comment 17

[Mike Kaply [:mkaply]]

Need one more change mentioned in patch.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/273bfd4eb4b2
Fix message in "Close Firefox" message box. r=mkaply,flod

Comment 19

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/273bfd4eb4b2