408536 - Find Bar: close button is not in the tab chain

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[philippe (part-time)]

As the subject says: can't access the close button on the new find bar by tab or shift-tab.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Is the close button in the chain in other similar cases?  (It isn't in our tabs or  the pop-up blocker because neither of those are in the tab chain at all right now--and have bugs about them--so I don't know that they are useful comparisons.)

Comment 2

[philippe (part-time)]

I don't see any other example right now, but given that all other buttons in the FindBar are in the tab chain, the close button should be in there as well. 

esc does close the Findbar, but as you noted for the popup blocker (bug 346803 comment 0) that might be a problem (potential conflicts).

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fixes close button (and baseline alignment and Match Case size)

Assuming we want to do this (and I can't think of a good argument not to, other than "all the other places we have close button, which aren't tab-accessible at all, don't" :P), here's a fixed nib.

Because it bothered me so much, I was unable to make this change without also fixing the alignment (baselines) of "Match case" and "Not found" and shrinking "Match case"'s bounding box to fit it (so that random whitespace is not a clickable part of the control); these two are listed in bug 408530 comment 0.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: v2, as above plus button spacing

As above, plus fixing the button spacing to 10px per AHIG for small buttons and bug 408530 comment 4.

Comment 5

[froodian (Ian Leue)]

Comment on attachment 295057 [details]
v2, as above plus button spacing

review given in channel.  summary: text is squished, put 10px on each side of close button, make separated items 24px apart from eachother.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: take 3, comments addressed

Consistent IBs, consistent IBs; my Camino for consistent IBs!

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 295189 [details]
take 3, comments addressed

Sean, can you take a look at this too/instead?

Comment 8

[Sean Murphy]

Comment on attachment 295189 [details]
take 3, comments addressed

r=murph

Comment 9

[Stuart Morgan]

Comment on attachment 295189 [details]
take 3, comments addressed

sr=smorgan

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on the trunk and the MOZILLA_1_8_BRANCH in advance of b3.