408578 - gtk: combobox pushed state

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[u294409]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en; rv:1.8.1.10) Gecko/20071213 Epiphany/2.20 Firefox/2.0.0.10
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en; rv:1.8.1.10) Gecko/20071213 Epiphany/2.20 Firefox/2.0.0.10

when combobox is clicked and menu is shown, combo should have pushed state everytime menu is shown.

Reproducible: Always

Steps to Reproduce:
1. open combobox
Actual Results:  
pushed state is shown when mouse button is still down and menu selection is done.

Expected Results:  
perfectly drawn combo :) .

bookmarks bar shows perfect behaviour [attachment done].

Comment 1

[u294409]

Attachment: similiar behaviour in boomarks bar

Comment 2

[u294409]

ping

Comment 3

[Ian Spence]

Attachment: Paints button as depressed when menu is open

2 line fix.

The first line paints it as depressed when the menu is open.
The second line causes the repaint when the menu closes.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Please file GTK theme bugs in Widget: Gtk.

Comment 5

[Reed Loden [:reed]]

Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v  <--  nsNativeThemeGTK.cpp
new revision: 1.130; previous revision: 1.129
done

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We should back this out to attempt to fix bug 410881

Comment 7

[Reed Loden [:reed]]

Backed out.

Comment 8

[Ian Spence]

Could this get relanded once if it is determined that it did not cause bug 410881?

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes, it seems we should reland this.

Comment 10

[Reed Loden [:reed]]

Relanded.

Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v  <--  nsNativeThemeGTK.cpp
new revision: 1.134; previous revision: 1.133
done

Comment 11

[pantsgolem]

This only seems to have fixed comboboxes in chrome, but not in content.

Comment 12

[u294409]

Exactly.

Comment 13

[u294409]

ping

Comment 14

[Ian Spence]

HTML comboboxes are broken in general.

Case and point:
1. Open 2 Firefox windows side-by-side (the one on the left should have an html combobox, so maybe a bugzilla page)
2. Click the combobox so that it shows its menu.  Notice that the button is not drawn as "depressed".
3. Click and hold the window decoration of the other window (where the min, max, close buttons are, but not on the buttons)

Notice that by activating the separate window, the combobox is not recieving those events, thus showing as depressed

Comment 15

[u294409]

Firefox is so hacky, and not native... Ahhh.
I wonder if some beautiful day we get perfect engine and browser.

Comment 16

[Reed Loden [:reed]]

Did you mean to request wanted1.8.1.x?

Comment 17

[Ian Spence]

Ugh, my apologies.  That happens to be the combobox I was using to reference in my post.

Comment 18

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #15)
> Firefox is so hacky, and not native... Ahhh.
> I wonder if some beautiful day we get perfect engine and browser.

Only with major changes to GTK. Note that Webkit/GTK uses a lot of our code for drawing GTK themes in Web pages.

Comment 19

[u294409]

I saw notice about it on some Wiki page.

Comment 20

[Julien "_FrnchFrgg_" RIVAUD]

I'm currently investigating how we could do that for the url bar too, since it would make it react as a ComboBoxEntry rather than a GtkCombo which is deprecated. The pb is that when the dropdown is open, no "open" attribute is set on the urlbar.

Comment 21

[u294409]

I'll be happy, if the GtkCombo and others looking like him would go away.

Comment 22

[Julien "_FrnchFrgg_" RIVAUD]

Attachment: Don't forget editable menulists [v1]

It makes editable menulists dropdown button remain pushed as long as the dropdown is open. It does not correct urlbar behaviour, since the urlbar doesn't set its open attribute on autocomplete opening.
There remains a glitch (which was present before): the dropdown button doesn't highlight on hover.

Comment 23

[Reed Loden [:reed]]

Checking in toolkit/content/widgets/menulist.xml;
/cvsroot/mozilla/toolkit/content/widgets/menulist.xml,v  <--  menulist.xml
new revision: 1.37; previous revision: 1.36
done
Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v  <--  nsNativeThemeGTK.cpp
new revision: 1.141; previous revision: 1.140
done

Comment 24

[u294409]

it should also work on websites

Comment 25

[Ian Spence]

Attachment: Paints html comboboxes as pressed when open

I'm posting this in case someone wants to take it and work with it.  This currently does the job except that if you close a combobox by clicking outside of the frame (so not on the button and not on the dropdown), then it doesn't cause a repaint. So the button stills looks depressed and will continue to do so until it is hovered.

Comment 26

[Thomas]

I'm not quite sure if I understand this bug.
In gtk you never actually _see_ the combobox in its pressed mode, as its items are drawn on top of it, in a way that the current selected item is just under the mouse.

Comment 27

[Thomas]

Attachment: Screenshot of nonpressed combobox in gtk

Oh, and btw., this only counts for in-content comboboxes. Comboboxes in toolbars should be drawn just like they are today. in beta 5.

Comment 28

[Thomas]

Attachment: Gtk combobox pressed

Comment 29

[Julien "_FrnchFrgg_" RIVAUD]

Under the menu, the combobox is in pressed state, IIRC. You can see it if you have an empty combobox (with an empty list to choose among). Currently our combobox menus don't popup on top of the combobox, but under. We'll probably have to live with it for Firefox 3; I don't know if it's easy or not to solve, and I've no time. I suspect Ian or Michael have roughly the same problem currently: crunch time...

Comment 30

[Victor Bielawski]

(In reply to comment #26)
> I'm not quite sure if I understand this bug.
> In gtk you never actually _see_ the combobox in its pressed mode, as its items
> are drawn on top of it, in a way that the current selected item is just under
> the mouse.

You do if the current item is the last one.

Comment 31

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:stransky, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 32

[Martin Stránský [:stransky] (ni? me)]

AFAIK outdated.