408696 - Don't show leading 0 for download dates

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Attachment 293481 [details] shows "December 05".. we should be showing "December  5" ?

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

Attachment: screenshot of v1

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 293531 [details] [diff] [review]
v1

we should strip the leading space for 1-9 to make this look right.

Comment 4

[Madhava Enros [:madhava]]

(In reply to comment #3)
> (From update of attachment 293531 [details] [diff] [review])
> we should strip the leading space for 1-9 to make this look right.

I agree about the extra space.  Otherwise, this looks good!

Comment 5

[Ed Lee :Mardak]

Attachment: screenshot of v1.1

Comment 6

[Ed Lee :Mardak]

Attachment: v1.1

Kill all spaces!

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 293539 [details] [diff] [review]
v1.1

r+a=me, thanks!

Comment 8

[Ed Lee :Mardak]

Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.115; previous revision: 1.114
done

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using my long-standing profile on:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2007121802
Minefield/3.0b3pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre)
Gecko/2007121801 Minefield/3.0b3pre

and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2007121802
Minefield/3.0b3pre

Comment 10

[Steve England [:stevee]]

Could this have caused bug 408818?

Comment 11

[Ed Lee :Mardak]

Yes.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry for missing the verification on Windows; my Mac build has a older history than Windows, which literally stopped at the 7-day marker.

I'll be sure to wait longer to verify it next time.

https://litmus.mozilla.org/show_test.cgi?id=5052

in-litmus+

Comment 13

[Ed Lee :Mardak]

Backed out to fix ui bustage for now. '05' is better than 'oawjfaoiwjfeloajwfelkwajflkawefjlakwefjaf5' :p

Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.120; previous revision: 1.119
done

Comment 14

[Ed Lee :Mardak]

Attachment: v2

Keep using %d and make it a number so leading 0s disappear.

Comment 15

[Shawn Wilsher :sdwilsh]

Comment on attachment 293812 [details] [diff] [review]
v2

r=sdwilsh

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 293812 [details] [diff] [review]
v2

a=beltzner for 1.9

Comment 17

[Ed Lee :Mardak]

Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.121; previous revision: 1.120
done

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with week-old DM profiles on:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2007123005 Minefield/3.0b3pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2007123004 Minefield/3.0b3pre

--and--

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2007123004 Minefield/3.0b3pre

For Real this time :-)