408737 - Hang with -moz-column and tall div inside short div

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Daniel Holbert [:dholbert]]

I'm getting some serious hangs with simple setups like:
  [-moz-column div]
    [short div]
      [tall div]

The length of the hang seems to be related to the ratio of tallHeight to shortHeight.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: testcase 1: short hang. (0px / 100px)

This mild testcase hangs for ~30 sec on my machine

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: testcase 2: long hang. (0px / 10000px)

This testcase is more serious -- I'm not sure how long it hangs.  (It's been going for several minutes, with no sign of stopping)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: testcase 3: long hang, nonzero height (10px / 100000px)

This testcase demonstrates that the hang doesn't depend on "short div" having exactly 0px height.

If we increase both short and tall heights, the hang remains.  This testcase hangs for more than a few minutes.  (I stopped it after a few minutes)

Comment 4

[Ria Klaassen (not reading all bugmail)]

Regression window Testcase 1 is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1194893940&maxdate=1194894899

Comment 5

[Daniel Holbert [:dholbert]]

Based on that, it looks like this is from bug 399407, since that bug deals with nsColumnSetFrame.cpp (-moz-column) and none of the other checkins seem related.

Comment 6

[Daniel Holbert [:dholbert]]

Yup -- backing out patch for bug 399407 fixes the hangs on all 3 testcases.

Comment 7

[Damon Sicore (:damons)]

Fantasai, making progress on this?  If you aren't looking at this, maybe dholbert can take a look here?

Comment 8

[fantasai]

It's fixed by the patches in bug 404215. Just need to write one that's good enough to check in. :)

Comment 9

[Damon Sicore (:damons)]

Great.  Thanks for the follow-up.

Comment 10

[Damon Sicore (:damons)]

We wouldn't hold the release for this if it were the last bug on the list (we're at that point now).  Moving to wanted1.9.0.x+.

Comment 11

[fantasai]

Should be fixed with the checkin to bug 404215