408749 - "ASSERTION: A block's child's next in flow's parent must be a block" with -moz-column, table stuff

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Loading the testcase triggers:

###!!! ASSERTION: A block's child's next in flow's parent must be a block!: 'nifBlock->GetType() == nsGkAtoms::blockFrame || nifBlock->GetType() == nsGkAtoms::areaFrame', file /Users/jruderman/trunk/mozilla/layout/generic/nsBlockFrame.cpp, line 3104

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

In this case nifBlock is a table caption frame.  Does the assert just need adjusting?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Maybe the assert should use a QueryInterface (or IsFrameOfType)?

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix assert

This patch creates nsBlockFrame* nsLayoutUtils::GetAsBlock which wraps QueryInterface. After this I should file a folloup bug to change all kBlockCID QIs to use GetAsBlock ... that'd be a good first bug.

Comment 6

[Daniel Holbert [:dholbert]]

OS --> All.  (I see this on Linux)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 293607 [details] [diff] [review]
fix assert

Looks good.

That said, should a caption be splitting like it does in this case?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

No. There is no way to reflow a caption continuation.

http://mxr.mozilla.org/seamonkey/source/layout/base/nsCSSFrameConstructor.cpp#10423

says "if there's a caption then replicate the caption", but it doesn't, as far as I can tell.

I'll post an additional patch to give captions unconstrained height.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: reflow captions with unconstrained height

Fixes the assertion independently of the other patch.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 293637 [details] [diff] [review]
reflow captions with unconstrained height

Very safe patch to silence an assertion

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

all checked in, plus the testcase as a crashtest.