408831 - add check on defunct for tree accessible

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

spun off bug 396930. Idea is to add virtual method isDefunct to call it in each method. Tree accessible should override the method to check row on validity.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

added IsDefunct(), I'll file following up bug to use that method everywhere.

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 294066 [details] [diff] [review]
patch

> -  NS_ENSURE_TRUE(mTree & mTreeView, NS_ERROR_FAILURE);
> +  if (IsDefunct())
> +    return NS_ERROR_FAILURE;
 
   PRInt32 rowCount = 0;
>    nsresult rv = mTreeView->GetRowCount(rowCount);
   NS_ENSURE_SUCCESS(rv, rv);
 
>    if (mRow < 0 || mRow >= rowCount) {
>      return NS_ERROR_FAILURE;
>    }

Isn't the unchanged part below the inserted "if (isDefunct())" statement also covered in IsDefunct() and should therefore be removed?

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 294066 [details] [diff] [review]
patch

r=MarcoZ with above fixed.

Comment 4

[alexander :surkov (:asurkov)]

thank you for the catch, Marco. forgot to remove :)

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 294066 [details] [diff] [review]
patch

a=beltzner for 1.9

Comment 6

[alexander :surkov (:asurkov)]

checked in

Comment 7

[Marco Zehe (:MarcoZ)]

Verified using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3