408834 - Page Info violates XUL box model

Status: VERIFIED FIXED

(SeaMonkey :: Page Info, defect)

Description

[[e-mail]]

Seen in the Error Console:

Warning: XUL box for hbox element contained an inline img child, forcing all its children to be wrapped in a block.
Source File: chrome://navigator/content/pageinfo/pageInfo.xul

Comment 1

[Daniel Brooks [:db48x]]

Cool. How do I start seeing this type of error? Also, do you have a line number?

Comment 2

[[e-mail]]

There's no line number for the error, because it's generated during frame construction - search nsCSSFrameConstructor for NeededToWrapXUL. The only tabs I looked at at the time were the general and media tabs (for bug 402286).

Comment 3

[Philip Chee]

Seems to be fixed Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.9.1b4pre) Gecko/20090413 SeaMonkey/2.0b1pre

Comment 4

[Philip Chee]

Steps to reproduce from Bug 437864 Comment 0

1. Load URL page.
2. Page Info > Media.
3. Select the SWF line.

Comment 5

[Edmund Wong (:ewong)]

Attachment: Changed img display to block.

Comment 6

[Philip Chee]

Does this stop the error message from happening in the test case in Comment 4?

Comment 7

[[e-mail]]

Comment on attachment 623054 [details] [diff] [review]
Changed img display to block.

Bug 522850 doesn't look like being fixed soon but just in case it might help to reorder the lines:
#thepreviewimage {
  display: block;
  /* This following entry can be removed when Bug 522850 is fixed. */
  min-width: 1px;
}

Comment 8

[Edmund Wong (:ewong)]

Attachment: Changed img display to block. (v2)

Comment 9

[Edmund Wong (:ewong)]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/6296536b1671

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to Philip Chee from comment #6)
> Does this stop the error message from happening in the test case in Comment
> 4?

[Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/15.0 Firefox/15.0a1 SeaMonkey/2.12a1] (2012-05-21-00-30-14-comm-central-trunk)

Bug still there, as expected.

[Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/15.0 Firefox/15.0a1 SeaMonkey/2.12a1] (2012-05-23-00-30-03-comm-central-trunk)

V.Fixed.