408842 - Improve version dependencies of language packs

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Robert Kaiser]

As of bug 397246, ChatZilla language packs are being generated as dependent add-ons.
Currently, they depend on a a ChatZilla with minVersion of @CHATZILLA_VERSION@ and a maxVersion @CHATZILLA_VERSION@.* which is suboptimal for the follwoing reason (taken from #developers):
<Gijs> if the current chatzilla version is 0.9.79
<Gijs> then they will get max version 0.9.79.*
<Gijs> but then if we release .1
<Gijs> and they rebuild it, they will have 0.9.79.1.*

The solution should be as follows:
<Gijs> couldn't you do:
<Gijs> 1. suffix .*
<Gijs> 2. replace /(\d+\.\d+\.\d+)\.\d+\.\*/$1.*
<KaiRo> Gijs: well, we'd also need to set the minVersion to /(\d+\.\d+\.\d+)\.\d+\.\*/$1
<Gijs> KaiRo: good point. Could you? :)
<Gijs> pretty please, sugar etc.? :)
<KaiRo> Gijs: which means we need to look into the makefile and perl logic and use a different var in the file... which surely can be done, but I'd rather do it in a followup patch, if possible

Comment 1

[Robert Kaiser]

Attachment: generate a base version from ChatZilla version and make langpack compat with all derived versions

This patch generates a "base version" out of the ChatZilla version number with max. three numbers, i.e. a 0.9.79.1 ChatZilla version is cut to a 0.9.79 base version, and langpacks are made compatible with 0.9.79-0.9.79.*

Comment 2

[Robert Kaiser]

oh, and I ported James' quoting fix from makexpi.sh to makelocalexpi.sh as well in this patch, as it's a very simple fix.

Comment 3

[:Gijs (he/him)]

Comment on attachment 294297 [details] [diff] [review]
generate a base version from ChatZilla version and make langpack compat with all derived versions

And this is a bit too big for me to do quickly. I'm not around for the next week and a half, so transferring r? to Silver.

Comment 4

[James Ross]

Comment on attachment 294297 [details] [diff] [review]
generate a base version from ChatZilla version and make langpack compat with all derived versions

There is one small issue: instead of using
  \+
you must use
  \{1,\}
Otherwise, it will fail on FreeBSD (don't ask).

r=silver with that change.

Comment 5

[Robert Kaiser]

Thanks, checked in with that sed-regex change. yay for cross-platform compatibility!