408888 - [pl] web services review for Firefox3 for Poland

Status: VERIFIED FIXED

(Mozilla Localizations :: pl / Polish, defect)

Description

[Mic Berman]

logging bug from IRC chat of today to make the following recommended changes:
search: swam BKI with new service from same provider (FBC)
RSS readers: remove my yahoo and bloglines as they are not available in polish
change the search order to:
 Google, WP, Allegro, Merlin, PBI/FBC, Enc. PWN, Wiki
marcoos - please add gandalf (can't find his right email)

Comment 1

[Marek Stępień [:marcoos, inactive]]

Just to make things clear, by "BKI" Mic means "PBI".

Comment 2

[Marek Stępień [:marcoos, inactive]]

Attachment: Update region.properties

We're not changing PBI to FBC yet, as FBC isn't yet as user-friendly as the old PBI. But we want to do it the moment FBC incorporates PBI, probably in a dot-release.

Also, I remember people from Merlin talking about search suggestions some time after 2.0. I'd like to reach to them and update the merlin-pl.xml searchplugin with an appropriate link to the JSON resource, if it's ready. Does it make sense? I mean, it's not too late yet, right?

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 295970 [details] [diff] [review]
Update region.properties

This won't work, r-. I'm not sure why we came up with that idea of extensive ordering, really. If we really want this, we need to make changes to firefox-l10n.js, sadly. And yuck.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 295970 [details] [diff] [review]
Update region.properties

PS: I can't set approval1.9, let's just use reviews from me for the reviews.

Comment 5

[Marek Stępień [:marcoos, inactive]]

Right, so what should I do with this now:
* hack firefox-l10n.js?
* revert to the 2.0 ordering (Google 1st, all the others alphabetically)?
* set Google 1st, WP.pl 2nd, all the rest alphabetically? (I can now recall that the number 2 was supported, but 3+ not)

And the idea of extensive ordering was Mic's. :)

Comment 6

[Axel Hecht [:Pike]]

Let's ask Mic.

Comment 7

[Mic Berman]

the idea for extensive ordering came when we built the guidelines thinking it made more user sense to order in groups of search plug in types. more can bet seen in bug 407922 and 380785. I did not realize the technical impacts to L10n - I'm very sorry about that. Had i known I would have left it alpha-order. I'll talk with Beltzner about this and post comments following.

Comment 8

[Mike Schroepfer]

Comment on attachment 295970 [details] [diff] [review]
Update region.properties

Please re-nom once approvals are done.

Comment 9

[Reed Loden [:reed]]

Comment on attachment 295970 [details] [diff] [review]
Update region.properties

Removing nom due to r-

Comment 10

[Mic Berman]

updated bug 407922 - if you wish to create a category based order as per opening of this bug, then you can do so and that'd be a better user experience. if you don't wish to go through the hassle, google first and alpha following is fine too.

Comment 11

[Mic Berman]

any update on potential mailto protocol local protocol handlers?

Comment 12

[Marek Stępień [:marcoos, inactive]]

Is the ordering now possible? If yes, we can do that (with the minused patch ;-)) if not - Google going first, others alphabetically sounds OK, too.

Per this document <http://wiki.mozilla.org/QA/Firefox3/TestPlan/Content_Handling_-_Web_Protocol_and_Application> I assume that en-US is supposed to have four mailto handlers, so if the possible number is 4, I'd go with the following:

- gmail
- onet.pl
- wp.pl
- interia.pl

The three non-Google services are the three biggest web portals in Poland (by number of real users, according to Gemius/Megapanel). The fourth biggest portal (gazeta.pl) has recently merged its webmail service with gmail, so it doesn't make sense to include it here separately, I think; so if we had an option of five handlers, o2.pl would be my bet.

Of course all of these services should be contacted first, as this needs not only their permission, but also implementing the API on their side.

Comment 13

[Mic Berman]

Hi marek, let's leave it normal L10n way i.e., google and then alpha
the referring bug I listed in comment 10 has since been discussed and looks like we will not be implementing any change to en-US side for ordering. Gavin can provide more technical reasons why if needed.

for mailto the number in en-US is aimed to be 3, guidelines listed here: http://wiki.mozilla.org/Firefox_web_services_guidelines
the url you refer to above was for discussion. the 3 is a guideline, it can be more if you recommend it (given number of users on differing services).

and you are right we need to contact everyone and get a url built. SO, why don't we do this contact top 3 we want and see if we can get them to give us permission and url's asap (even in time for Beta 4 +10 days or so from now). and then include those that respond. 

can you help me get in touch with these people? i need contact emails and then i can send email with url's for how to build etc.

thanks

Comment 14

[Marek Stępień [:marcoos, inactive]]

wp.pl: [e-mail]
Interia.pl: [e-mail]

For Onet, I couldn't find a suitable e-mail address. This form should be OK, though: http://ofirmie.onet.pl/3175,,,EN,kontakt.html - if not, [e-mail] is their general e-mail address.

Comment 15

[Mic Berman]

tried the form for onet, no luck (get error messages). so sent email. copied you on other emails to track progress.

Comment 16

[Marek Stępień [:marcoos, inactive]]

What you should also know, is that I am an Interia.pl employee myself, working as a web developer. 

This means I should probably be able to help with Interia's side of this issue (if the management decides that they want this), but my contract prohibits me from any co-operation with Onet and WP, so I can't really help with the negotiations with other portals. 

I suppose other Polish L10n team members can talk with (and help) Onet and WP, if needed.

Comment 17

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #12)
> Is the ordering now possible? If yes, we can do that (with the minused patch
> ;-)) if not - Google going first, others alphabetically sounds OK, too.

Let's just stick with the normal, Google-only ordering for now.

Comment 18

[Marek Stępień [:marcoos, inactive]]

Attachment: Drop English feed handlers

In the meantime, let's get the feed handlers done.

Comment 19

[Zibi Braniecki [:zbraniecki][:gandalf]]

I can get in touch with Onet and Wp.

Mic, what you'd like me to get from those?

Comment 20

[Mic Berman]

Hi Gandalf,
here's the email I sent the others, you can use it as a template:

We would like your permission and support to include your service as a mailto default protocol handler in the upcoming release of Firefox 3 in Polish.

We will need you to provide us with the appropriate url to enable your service.

There are some instructions here:

We need a URL that accepts those parameters encoded as an embedded mailto: URL, as specified by the section of the WhatWG link pointed to by
<http://whatwg.org/specs/web-apps/current-work/#custom-handlers>.

If you need more explanation email us back for clarification.

Thanks

Comment 21

[Mic Berman]

Zbigniew - was my comment #20 clear? lmk if you need help. Otherwise post response and contact information from Onet and Wp when you get it

Gavin, can you review the patch that's here

Comment 22

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 303357 [details] [diff] [review]
Drop English feed handlers

>Index: pl/browser/chrome/browser-region/region.properties

>+browser.contentHandlers.types.2.title=Google Reader

Please change this to just "Google". See bug 357371.

Comment 23

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #22)
> >+browser.contentHandlers.types.2.title=Google Reader
> Please change this to just "Google". See bug 357371.

Checked in, with review comment addressed.

Comment 24

[Marek Stępień [:marcoos, inactive]]

Interia.pl is ready.

The mailto: URL handler URL for Interia's webmail is:
http://poczta.interia.pl/mh/?mailto=%s

The whole mailto: URL scheme is supported as defined in RFC 2368. So it accept mailto URLs like these:

mailto:[e-mail]&subject=subject&body=Hello&cc=[e-mail]

I know that Stanislaw Stanuch sent Mic an e-mail with approval a few days ago.

Comment 25

[Mic Berman]

here is the approval email from Stanuch:


----- Original Message -----
From: "Stanislaw M. Stanuch" <[e-mail]>
To: [e-mail]
Cc: "Kuciel Dominik"  "Sebastian Wojnarowski" 
Sent: Monday, February 18, 2008 7:39:18 AM GMT -05:00 US/Canada Eastern
Subject: Interia: Firefox 3, mail default

Hi Mic,

Thx for you proposition to include a mailto as a one of default protocol handler in polish version in comming soon Firefox 3. We're at Interia big fun of Firefox and Open Source, so it's good news for us.

The URL you ask in you mail will be ready at Tue or Wed this week and I or someone from our technical team will sent it to you.

Thx Stas

Comment 26

[Marek Stępień [:marcoos, inactive]]

Should I make a patch for brand.properties just with Interia in it for now, or wait until the other providers respond and have them all in one patch?

I've seen Yahoo added for en-US while still waiting for Google (in bug 413630 comment 30)...

Comment 27

[Marek Stępień [:marcoos, inactive]]

I mean, region.properties...

Comment 28

[Axel Hecht [:Pike]]

Mic, I think that comment 26 is for you.

Could I get a in-one-comment recap for what we intend to do on the search side of life now?

Comment 29

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #28)
> Could I get a in-one-comment recap for what we intend to do on the search side
> of life now?

Effectively, we're sticking with what Fx 2 had in alphabetical order, until PBI and FBC merge (which should happen after 3.0), adding search suggestions for Merlin, when/if they make it.

As for the mailto handler, there's bug 420756 which blocks adding any default protocol handlers for the time being...

Comment 30

[Mic Berman]

As for the mailto handler, there's bug 420756 which blocks adding any default
protocol handlers for the time being...

does that mean you'll take en-US defaults? last i heard from team you were going to investigate any local options, was there nothing?

Comment 31

[Mic Berman]

re comment #26. i am ok with two patches e.g., do inertia now and when we hear from others we'll add them in. ok all?

Comment 32

[Marek Stępień [:marcoos, inactive]]

Mic, I don't understand your comment 30. We're of course taking Interia and GMail (and, if they're ready, Onet and WP), but bug 420756 must be fixed first, so that adding handlers doesn't break anything.

For the calendar handler, I only know of Google Calendar as being both usable and in Polish, so we may stick to en-US defaults for the calendar part.

Comment 33

[Mic Berman]

Marek, apologies for the confusion. From your comment I had the impression you were asking me based on my review not due to the technical issue - that's a result of me working too late into night and wanting to be sure I wasn't blocking progress ;)
understood now about bug 420756 and issues there and therefore waiting :)

Comment 34

[Marek Stępień [:marcoos, inactive]]

Attachment: Add Interia.pl, rev defaultHandlersVersion to 1

OK, this should do it.

Note that this is supposed to land only after bug 420756 gets fixed.

Comment 35

[Marek Stępień [:marcoos, inactive]]

E-mailed Merlin, reminding them about search suggestions support.

Comment 36

[Axel Hecht [:Pike]]

Comment on attachment 309542 [details] [diff] [review]
Add Interia.pl, rev defaultHandlersVersion to 1

r=me, land with comment yadda yadda, y'know, I know.

Comment 37

[Marek Stępień [:marcoos, inactive]]

Checked in.

Comment 38

[Marek Stępień [:marcoos, inactive]]

Interia's mailto handler verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9b5pre) Gecko/2008031806 Minefield/3.0b5pre.

Mic, gandalf - any news from the other webmail providers?

Comment 39

[Mic Berman]

onet have not responded yet, i am trying again now.
for wp.pl - is this on me or gandalf?

Comment 40

[Marek Stępień [:marcoos, inactive]]

I though both were on you, I even got cced on an e-mail you sent to WP on Feb 14th. As I understand, WP did not reply to that e-mail?

Gandalf, did you contact Onet and/or WP regarding the mailto handler (comment 19 says you at leasted wanted to)...

Comment 41

[Mic Berman]

marek, just checking ;-)
I'll follow up on my emails and see if i can get a response. i will let you know if i need help.

sent another note to both today and copied you.

Comment 42

[Zibi Braniecki [:zbraniecki][:gandalf]]

I didn't get any response either, I contacted our PR agency to get a proper email addresses. Should happen today.

Comment 43

[Zibi Braniecki [:zbraniecki][:gandalf]]

I did email two people from WP and one from Onet according to emails received from MMd.

Let's wait :)

Comment 44

[Mic Berman]

permission received for PBI

Dear Michal,

I am contacting you as suggested by Mr Marek Stępień from Polish Firefox
team. I represent Poznań Supercomputing and Networking Center from
Poznań, Poland (http://www.man.poznan.pl/) which is a government funded
IT R&D institution. One of our projects is the Digital Libraries
Federation (http://fbc.pionier.net.pl) which is a freely accessible
search portal allowing to search through the resources of majority of
Polish digital libraries. It is based on the open OAI-PMH protocol.

We have implemented the OpenSearch plugin for our Digital Libraries
Federation and I was discussing the possibility of inclusion of this
plugin into the Polish release of the Firefox 3 with Mr Stępień.

As I am the person responsible for the Digital Libraries Federation
project, I would like to inform you, that we agree to have our search
plugin included in Polish Firefox 3.

Best regards,
Marcin Werla
Digital Libraries Team Leader
Poznan Supercomputing and Networking Center
Poznan, Poland

Comment 45

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #44)
> permission received for PBI

Actually, it's FBC (Federacja Bibliotek Cyfrowych; Digital Libraries Federation), the service that replaced PBI.

Comment 46

[Mic Berman]

yep, sorry, always get those two confused. To be clear: FBC is replacing PBI.

still outstanding some permissions and we're running low on time. let's check back in in a few days and then make a go/no go decision

Comment 47

[Marek Stępień [:marcoos, inactive]]

> still outstanding some permissions and we're running low on time.

Which ones? All the other services approve being in Firefox since the 1.x/2.x days... The only new ones are the mailto handlers and FBC, but they're already given the permissions.

As far as I know, we're only waiting for the mailto providers (Onet, Google and WP.pl) to have a working and spec-conformant mailto handler.

I should follow up with the PBI->FBC patch soon.

Comment 48

[Mic Berman]

marek - exactly - only waiting on mailto :)
sorry i wasn't more specific

Comment 49

[Marek Stępień [:marcoos, inactive]]

Attachment: Replace PBI with FBC

Comment 50

[Marek Stępień [:marcoos, inactive]]

We need to replace PBI with FBC on the branch as well, since PBI has gone permanently offline... 

That's not what we had expected of a government-run project. :/

Comment 51

[Axel Hecht [:Pike]]

Hrm. Does the suggest feature work? In my awesomebar-testing I only see empty results, i.e., view-source:http://fbc.pionier.net.pl/owoc/gossip?action=GossipSearchAction&query=po

yields 

["po",[],[]]

Comment 52

[Marek Stępień [:marcoos, inactive]]

Oops, it does work with the OpenSearch plugin they've sent to me, but I converted it myself to MozSearch and it stopped working. 

Somehow the order of the parameters is important here...

http://fbc.pionier.net.pl/owoc/gossip?query=po&action=GossipAction

["po",["pol","poznaniu","polskie","polska","poznańskiego","poznański","polski","pocztówka","politechniki","posiada"],["409804","190652","50224","70484","29760","111788","43664","8900","13708","7736"]]			 	

I'll submit a new patch in the evening.

Comment 53

[Zibi Braniecki [:zbraniecki][:gandalf]]

I got a new contact to WP, pinged already.

Comment 54

[Axel Hecht [:Pike]]

Marek, this is a server side issue, I pasted the params in a different order than you had them in the plugin. Just dropping the action param was good, too.

Gavin, being dependent on the order of the params sounds spec-breaking to me. Is it?

Marek, gandalf, I actually have more questions, do we have an explanation for the plethora of flags they want to have sent? I think we shouldn't send flags that aren't used, or that don't have good defaults on the site. In other words, I would expect at least some of those 7 params to have good defaults on the server side. Using those defaults on the server side would make the maintainance of those easier, too.

Comment 55

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #51)
> Hrm. Does the suggest feature work? In my awesomebar-testing I only see empty
> results, i.e.,
> view-source:http://fbc.pionier.net.pl/owoc/gossip?action=GossipSearchAction&query=po

Actually this URL now returns:

["po",["pol","poznaniu","polskie","polska","poznańskiego","poznański","polski","pocztówka","politechniki","posiada"],["409804","190652","50224","70484","29760","111788","43664","8900","13708","7736"]]			 	

I can't reproduce the ordering/no-ordering problem anymore.

I am going to ask them about reducing the number of params in a minute.

Comment 56

[Marek Stępień [:marcoos, inactive]]

Sent an e-mail to FBC. 

Comment 57

[Mic Berman]

permission and detail received from wp.pl for mailto:

----- Original Message -----
From: "Rafał Krzyżański" 
To: "Michal Berman" 
Cc: "Andrzej Butkiewicz" , "Robert Jaliński"
Sent: Tuesday, April 1, 2008 4:43:25 AM GMT -05:00 US/Canada Eastern
Subject: Re: Firefox 3 Polish

Hello

Thank you for your interest in poczta.wp.pl. You'll have our full support.

The URL necessary to enable the service would be:
"http://poczta.wp.pl/napisz.html?url=%s"


If there is anything else we could help you with concerning the subject,
please email us back.

Thanks
Klarki

-- 
Pozdrawiam
Rafał Krzyżański

Comment 58

[Marek Stępień [:marcoos, inactive]]

Marcin Werla (FBC) says they're going to limit the number of parameters soon.

The WP URL does not work for me at the moment with a mailto URL (and neither with an e-mail address)...

Comment 59

[Axel Hecht [:Pike]]

(In reply to comment #55)
> (In reply to comment #51)
> > Hrm. Does the suggest feature work? In my awesomebar-testing I only see empty
> > results, i.e.,
> > view-source:http://fbc.pionier.net.pl/owoc/gossip?action=GossipSearchAction&query=po
> 
> Actually this URL now returns:
> 
> ["po",["pol","poznaniu","polskie","polska","poznańskiego","poznański","polski","pocztówka","politechniki","posiada"],["409804","190652","50224","70484","29760","111788","43664","8900","13708","7736"]] 
> 

Actually, that seems to be down right now, I can't get to a result in either ordering.

Comment 60

[Mic Berman]

updated for Onet

--- Original Message -----
From: "Andrzej Margos" 
Sent: Wednesday, April 2, 2008 10:27:08 AM GMT -05:00 US/Canada Eastern
Subject: RE: Firefox 3 Polish, mail default <id:kkuk-7c6etn>

Hi,

We've slightly modified our implementation. 

Service endpoint is:
http://poczta.onet.pl/napisz.html?uri=%s
name: OnetPoczta

If there are any problems, feel free to inform us. 

Comment 61

[Marek Stępień [:marcoos, inactive]]

Onet seems to be working fine here.

So we're only waiting for WP and Gmail.

Comment 62

[Mic Berman]

Gmail has been confirmed will no land in Fx 3.0.0.0 but instead in Fx 3.0.0.1. That means we'll be doing an l10n update in 3.0.0.1 for this as well. 

WP  - are they copied on this bug re comment #58? do they know there is an issue?

Comment 63

[Marek Stępień [:marcoos, inactive]]

No, only Mozilla employees and Aviary.pl localization team members are cc'ed here. BTW, I don't think we should bugspam e.g. the FBC guys with webmail-related stuff and vice versa...

Gandalf, can you contact WP? The URL they provided does not work - the compose window opens, but the "to" field is empty, regardless of what we pass to it as %s.

Comment 64

[Marek Stępień [:marcoos, inactive]]

Attachment: Add Onet, rev defaultHandlersVersion to 2

Comment 65

[Marek Stępień [:marcoos, inactive]]

Attachment: Replace PBI with FBC, take #2 (landed on branch)

FBC's Agnieszka Lewandowska provided me with a new URL to their search results. They've dropped almost all of the parameters, leaving just the "query" and "action" ones, which she says is required by their "website architecture".

We need this patch also on the 1.8 branch, as PBI went offline and seems to be dead.

Comment 66

[Marek Stępień [:marcoos, inactive]]

Regarding the sometimes non-working suggestions in FBC plugin, they've confirmed this issue and are going to fix it, the URL for the suggestions won't change, though, so nothing really blocks replacing PBI with FBC now.

Comment 67

[Axel Hecht [:Pike]]

Comment on attachment 313185 [details] [diff] [review]
Replace PBI with FBC, take #2 (landed on branch)

r=me, this looks much cleaner, thanks. Check-in with the common comments blurb, please?

Comment 68

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #67)
> (From update of attachment 313185 [details] [diff] [review])
> r=me, this looks much cleaner, thanks. Check-in with the common comments blurb,
> please?

Will check this in later today. Can you approve this patch for 1.8.0.x as well, please?

Comment 69

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #68)
> Will check this in later today.

FBC plugin checked-in, PBI cvs-removed on trunk. Now waiting for approval to do the same on the branch.

Also, still waiting for a review of attachment 313183 [details] [diff] [review].

Comment 70

[Marek Stępień [:marcoos, inactive]]

Gandalf: yesterday on Jabber you told me you'd contact the WP guys today. Any update on this?

Comment 71

[Axel Hecht [:Pike]]

Gaaaaaandalf! Any news from WP?

Comment 72

[Mic Berman]

fwiw - if WP doesn't land at least we have one polish mailto provider: onet.pl i'd be happy with shipping that. what about you Marek? maybe we can add WP after RC1. Also I am mailing WP as well.

Comment 73

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #72)
> fwiw - if WP doesn't land at least we have one polish mailto provider: onet.pl

Two, in fact. Interia and Onet.

> i'd be happy with shipping that. what about you Marek?
> maybe we can add WP after RC1. Also I am mailing WP as well.

Well, if we can ship en-US without Google (which is something I would have called unbelievable just a month ago), we can ship pl without WP...

Comment 74

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #54)
> Gavin, being dependent on the order of the params sounds spec-breaking to me.
> Is it?

Sorry for the delay - looks like this has been sorted out anyhow? For what it's worth, I don't think the OpenSearch spec says anything about it, but it's certainly strange behavior from a plain-old-CGI point of view.

Comment 75

[Marek Stępień [:marcoos, inactive]]

> Sorry for the delay - looks like this has been sorted out anyhow? For what it's
> worth, I don't think the OpenSearch spec says anything about it, but it's
> certainly strange behavior from a plain-old-CGI point of view.

The real problem was that Pike was using a wrong URL and I only realized it after I've sent an invalid bug report to FBC. ;)

OK, to recap the current situation, what we still need for 3.0 are two things:
* review for the Onet patch from Pike
* en-US calendar handlers finalized, so we can steal them ;)

If wp.pl can't make it one time, it's OK for us to ship 3.0 with just Interia and Onet, but we'd like to have WP in a dot release, as soon as they're ready. Same goes for gmail.

What we REALLY NEED for 2.0.0.x is the approval of the FBC patch - we're currently shipping 2.0.0.x with a non-working search plugin!

Comment 76

[Axel Hecht [:Pike]]

(In reply to comment #75)
> > Sorry for the delay - looks like this has been sorted out anyhow? For what it's
> > worth, I don't think the OpenSearch spec says anything about it, but it's
> > certainly strange behavior from a plain-old-CGI point of view.
> 
> The real problem was that Pike was using a wrong URL and I only realized it
> after I've sent an invalid bug report to FBC. ;)

I don't think so. I think that it's still broken. It might depend on timing instead of order of the params, but it's broken still.

> OK, to recap the current situation, what we still need for 3.0 are two things:
> * review for the Onet patch from Pike
> * en-US calendar handlers finalized, so we can steal them ;)

en-US handlers are finalized for 3.0, want to create a new patch?

> If wp.pl can't make it one time, it's OK for us to ship 3.0 with just Interia
> and Onet, but we'd like to have WP in a dot release, as soon as they're ready.
> Same goes for gmail.

Fine.

> What we REALLY NEED for 2.0.0.x is the approval of the FBC patch - we're
> currently shipping 2.0.0.x with a non-working search plugin!

No, you don't need an urgent approval, 2.0.0.14 is a security drill and I don't see us taking this change, and 2.0.0.15 is weeks out. That's unfortunate, but the way it is, and not our fault.

I won't deal with any branch approvals until RC1 is out of the water.

Comment 77

[Zibi Braniecki [:zbraniecki][:gandalf]]

Sorry for late answer

From MMd I got an email address to mrs. Natalia Hatalska from wp ([e-mail]), I did email her, and she replied that she'll contact someone who's in charge of these things.

Didn't get any contact later, so I poked her yesterday. Will see what it'll result in on Monday

Comment 78

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #76)
> I don't think so. I think that it's still broken. It might depend on timing
> instead of order of the params, but it's broken still.

No, you were using this:

view-source:http://fbc.pionier.net.pl/owoc/gossip?action=GossipSearchAction&query=po

instead of this:

view-source:http://fbc.pionier.net.pl/owoc/gossip?action=GossipAction&query=po

There's never been a 'GossipSearchAction' in the plugin... :)

Comment 79

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #76)
> en-US handlers are finalized for 3.0, want to create a new patch?

As en-US only has 30Boxes, and that's what pl already has, there's no need for a new patch, the Onet (attachment 313183 [details] [diff] [review]) one will suffice.

http://mxr.mozilla.org/l10n/source/pl/browser/chrome/browser-region/region.properties#25
http://mxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser-region/region.properties#27

Comment 80

[Axel Hecht [:Pike]]

Oh, details :-)

Anyways, looking at attachment 313183 [details] [diff] [review], do we want yahoo mail in there, too? If so, should we obsolete that attachment or bump the handler version twice with a follow up patch for yahoo?

Comment 81

[Marek Stępień [:marcoos, inactive]]

If we were to add yet another mail provider, it would make more sense to have O2.pl than Yahoo.

Interia, Onet, WP and O2 each have millions of users. I don't have accurate data for Yahoo, but I suppose the number of mail.yahoo.pl accounts is measured in thousands at most. 

Comment 82

[Mic Berman]

i am ok to ship with the two polish mailto handlers we have now and no yahoo given that the yahoo numbers in poland are so low AND they are not in Polish

Comment 83

[Axel Hecht [:Pike]]

Comment on attachment 313183 [details] [diff] [review]
Add Onet, rev defaultHandlersVersion to 2

r=me on this patch then, please check-in with comment referencing bug, review, and change, as usual.

Comment 84

[Marek Stępień [:marcoos, inactive]]

Checked in.

Comment 85

[Mic Berman]

per pike's suggestion in an IRC chat, i'm going to spin off the outstanding mailto for WP into another bug so we can close this one for RC1. marek/pike can we resolve fixed from a technical view? if so, make it so

Comment 86

[Marek Stępień [:marcoos, inactive]]

OK, summing stuff up:

We're shipping with the following:
* search plugins (asterisk means with suggestions support)
- Google       (*)
- WP.pl
- Allegro
- Wikipedia    (*)
- Encyklopedia PWN
- Merlin.pl
- FBC          (*)

* mailto handlers
- Poczta Interia.pl
- OnetPoczta

* calendar handlers
- 30 Boxes (copied from en-US)

The above list could have been nicer (GMail, Poczta WP), but it's still OK.

I'm OK with spining off the other services to another bug; resolving this as fixed, then. 

Comment 87

[Axel Hecht [:Pike]]

VERIFIED, against reference http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/1f46480dc42f/reference/HEAD/pl/.

Comment 88

[Marek Stępień [:marcoos, inactive]]

I did some common tests on all handlers shipping with Fx 3 pl, and the results are quite nice. All the three webmail systems improved, if I had ran these tests a week or too ago, there would have been many more red cells in the results table. 

I put the results in our wiki:
http://wiki.aviary.pl/Mozilla:Firefox:mailto#Macierz_test.C3.B3w

This page is in Polish, but you should understand what a green "OK" means and what the various "mailto:" URLs are supposed to be doing (some of the tests where taken from the en-US Yahoo bug).

Comment 89

[Axel Hecht [:Pike]]

Comment on attachment 313185 [details] [diff] [review]
Replace PBI with FBC, take #2 (landed on branch)

Could we get a patch to removed-files.in to go with this?

Comment 90

[Marek Stępień [:marcoos, inactive]]

Pike, it seems that you patched removed-files.in by yourself in April.

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/installer/removed-files.in&rev=1.50#106

Comment 91

[Marek Stępień [:marcoos, inactive]]

Attachment: removed-files.in 1.8 patch

Ahh, you meant the 1.8 branch. Here goes the removed-files.in patch for it. :)

Comment 92

[Axel Hecht [:Pike]]

Comment on attachment 323644 [details] [diff] [review]
removed-files.in 1.8 patch

r=me, requesting approval1.8.1.15 on this one.

Comment 93

[Daniel Veditz [:dveditz]]

Comment on attachment 323644 [details] [diff] [review]
removed-files.in 1.8 patch

Approved for 1.8.1.15, a=dveditz

Comment 94

[Axel Hecht [:Pike]]

Comment on attachment 313185 [details] [diff] [review]
Replace PBI with FBC, take #2 (landed on branch)

a=me, I'm going to land this part of the patch myself, just to make it lands in time.

Comment 95

[Daniel Veditz [:dveditz]]

Checked in attachment 323644 [details] [diff] [review] to the branch. That should be done for this bug, right?

Comment 96

[Axel Hecht [:Pike]]

Yes, thanks.

We'd love to get some branch verification, if done, please change the fixed1.8.1.15 keyword to verified....

Comment 97

[Marek Stępień [:marcoos, inactive]]

verified1.8.1.20, for what it's worth. :)