Can't --disable-xpcom-obsolete in a 1.8 branch static build

VERIFIED FIXED

Status

()

Core
Build Config
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Mark Mentovai, Assigned: Mark Mentovai)

Tracking

({verified1.8.1.12})

1.8 Branch
verified1.8.1.12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
We no longer use the xpcom-obsolete module and would like to remove it from Camino 1.6, based on the 1.8 branch.

--disable-xpcom-obsolete doesn't work in 1.8 branch static builds, because mozilla/config/static-config.mk always requires libxpcom_compat (the xpcom-obsolete module) unless building minimo.

Currently, the check in static-config.mk looks like this:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/config/static-config.mk&rev=3.23.2.6&mark=130-133#130

I'd like to change this to check for MOZ_NO_XPCOM_OBSOLETE instead, as is done on the trunk:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/config/static-config.mk&rev=3.42&mark=112-115#112

ifndef MOZ_NO_XPCOM_OBSOLETE is exactly equivalent to ifdef MINIMO for all known builds.  MOZ_NO_XPCOM_OBSOLETE is only set with --enable-application=minimo or with --disable-xpcom-obsolete.  No official Tinderbox configuration on the 1.8 branch uses --disable-xpcom-obsolete.  This can be verified with the following mxr searches:

http://mxr.mozilla.org/mozilla1.8/search?string=MOZ_NO_XPCOM_OBSOLETE
http://mxr.mozilla.org/mozilla1.8/search?string=disable-xpcom-obsolete&find=&findi=&filter=&tree=mozilla1.8

Because ifndef MOZ_NO_XPCOM_OBSOLETE is exactly equivalent to ifdef MINIMO, this patch has zero impact and is completely safe to take on the 1.8 branch.
(Assignee)

Comment 1

10 years ago
References to "ifdef MINIMO" in previous comment should be to "ifndef MINIMO."
(Assignee)

Comment 2

10 years ago
Created attachment 293792 [details] [diff] [review]
Static builds should only link with xpcom-obsolete when it is enabled
Attachment #293792 - Flags: review?(ted.mielczarek)
Attachment #293792 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

10 years ago
Comment on attachment 293792 [details] [diff] [review]
Static builds should only link with xpcom-obsolete when it is enabled

We would like this on the 1.8 branch to be able to --disable-xpcom-obsolete for Camino.

As stated above, this change has no impact at all on any other product, because it replaces |ifndef MINIMO| with |ifndef MOZ_NO_XPCOM_OBSOLETE|, and on the 1.8 branch, MOZ_NO_XPCOM_OBSOLETE is only ever true when building minimo or when --disable-xpcom-obsolete is specified.  No currently known build ever specifies --disable-xpcom-obsolete.

This change was already made on the trunk on 2006-04-20.
Attachment #293792 - Flags: approval1.8.1.12?
(Assignee)

Updated

10 years ago
Blocks: 408959
Comment on attachment 293792 [details] [diff] [review]
Static builds should only link with xpcom-obsolete when it is enabled

Dougt: you OK with this change?
Attachment #293792 - Flags: review?(dougt)

Comment 5

10 years ago
Comment on attachment 293792 [details] [diff] [review]
Static builds should only link with xpcom-obsolete when it is enabled

I am okay with this.  it is good that the obsolete libs are dead.  maybe we should just stop building it?
Comment on attachment 293792 [details] [diff] [review]
Static builds should only link with xpcom-obsolete when it is enabled

approved for 1.8.1.12, a=dveditz for release-drivers
Attachment #293792 - Flags: approval1.8.1.12? → approval1.8.1.12+
(Assignee)

Comment 7

10 years ago
Checked in on MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1.12
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 8

10 years ago
Comment on attachment 293792 [details] [diff] [review]
Static builds should only link with xpcom-obsolete when it is enabled

marking +
Attachment #293792 - Flags: review?(dougt) → review+
Verified that it is checked in for 1.8 branch. Whee.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.12 → verified1.8.1.12
You need to log in before you can comment on or make changes to this bug.