Closed
Bug 409003
Opened 17 years ago
Closed 17 years ago
Rotate View is always disabled
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: andreas.treumann, Assigned: sipaq)
Details
(Keywords: regression)
Attachments
(1 file)
1.48 KB,
patch
|
berend.cornelius09
:
review+
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE: =================== - open the calendar view - go to the 'View/Current View' menu - check the 'Rotate View' entry RESULT: ======= - the 'Rotate View' entry is always disabled EXPECTED RESULT: ================ - the 'Rotate View' entry should be enabled REPRODUCIBLE: ============= - always First Build with this Bug: 20071130
Flags: blocking-calendar0.8?
Reporter | ||
Updated•17 years ago
|
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 1•17 years ago
|
||
No need to block on this. This is a regression that Berend introduced with his big menu cleanup patch. I'll post a patch shortly.
Flags: blocking-calendar0.8?
Assignee | ||
Comment 2•17 years ago
|
||
Berend, since you introduced the regression, it's probably best if you do the review.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #293855 -
Flags: review?(Berend.Cornelius)
Comment 3•17 years ago
|
||
Comment on attachment 293855 [details] [diff] [review] Patch The patch works very fine and fixes the described problem. However it leaves one closely related problem aside: When you switch to the multiweek view or monthview after having checked the rotation to "true" the menu-item will still be checked although we do not provide any rotation in these views. If you want to you can fix this within this issue, too, but you don't have to.
Attachment #293855 -
Flags: review?(Berend.Cornelius) → review+
Assignee | ||
Comment 4•17 years ago
|
||
Fix checked in on HEAD and MOZILLA_1_8_BRANCH. Thanks for spotting the issue with the checked menuitem in month- and multiweek-View, Berend. I fixed this by removing the 'persist="checked"' attribute from the menuitem as well.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Updated•17 years ago
|
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•