Closed Bug 409114 Opened 16 years ago Closed 16 years ago

Share ssh-agent instances across rxvt instances


(Firefox Build System :: MozillaBuild, task)

Windows XP
Not set


(Not tracked)



(Reporter: bent.mozilla, Assigned: bent.mozilla)




(1 file)

Attached patch PatchSplinter Review
Right now there are two instances of ssh-agent that get created per instance of rxvt. Attached patch uses a script that I found here:
Attachment #293962 - Flags: review?(ted.mielczarek)
I guess the bad thing about this is that the single instance of ssh-agent will live forever (until shutdown)... but it's pretty small so I dont think anyone will really care. This makes it so that you only have to enter your password once per login session.
Comment on attachment 293962 [details] [diff] [review]

>+  ps -ef | grep ${SSH_AGENT_PID} | grep ssh-agent$ > /dev/null || {

FWIW, $SSH_AGENT_PID will work on MSYS afaict. Probably doesn't matter but I just wanted to mention it.
I emailed the script author asking for licensing permission.
Component: Build & Release → MozillaBuild
QA Contact: build → mozillabuild
Assignee: nobody → bent.mozilla
Comment on attachment 293962 [details] [diff] [review]

r+ but pending licensing I guess.  :-/
Attachment #293962 - Flags: review?(ted.mielczarek) → review+
This patch doesn't fix the newly born start-l10n.bat, too.
That file looks ok to me... I'm removing the ssh-agent lines from the others and start-l10n.bat doesn't have any reference to ssh-agent.
Hrm. That seems to be a double merge error. Myk landed ssh-agent support for all but one start script, start-msvc9.bat, which I used to create start-l10n.bat, for no particular reason.

Sounds like a good idea to sync all the start scripts in this regard.
That's what this patch will do - I'm backing out Myk's ssh-agent additions and then adding a profile script to do the real ssh-agent work. You got lucky :)
Gosh, I blame the elves for me not reading. Sorry.
Ted, Joseph Reagle contacted me via email and released the script under the GPL. Need a new patch or can I just add that on checkin?
Just add it, that's fine.
Fixed on trunk.
Closed: 16 years ago
Resolution: --- → FIXED
Mass re-assign of MozillaBuild bugs into
Product: → Firefox Build System
You need to log in before you can comment on or make changes to this bug.