409232 - pass in product name to verify-locales.pl

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

verify-locales.pl currently only supports Firefox releases. It will soon support Firefox Betas (bug 408868), but alphas are named differently. One way to solve this is to pass in the app name to verify-locales.pl. This has the additional benefit of being able to support Thunderbird (and other products?).

One thing I noticed is that Alpha naming may have to change a bit. Currently, installers on windows are named, ie, "Gran Paradiso Alpha 6.exe". To support this cleanly we could change that to "Gran Paradiso Setup Alpha 6.exe".

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

We could also integrate verify-locales.pl into Bootstrap, as we did with groom-files.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to comment #1)
> We could also integrate verify-locales.pl into Bootstrap, as we did with
> groom-files.
> 

I like this idea.

Comment 3

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #2)
> (In reply to comment #1)
> > We could also integrate verify-locales.pl into Bootstrap, as we did with
> > groom-files.
> I like this idea.
me too...

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

This is the script we run on stage, like this
  ~/bin/verify-locales.pl -m ../../batch-source/rc${RC}/mozilla/${APP}/locales/shipped-locales

rather than the l10n verify step in Bootstrap (metadiff).

Comment 5

[[e-mail] (:bhearsum)]

Attachment: [checked in] pass in product name to verify-locales.pl

Pretty straightforward patch, I think.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: bootstrap patch to accomodate new verify-locales.pl

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 309955 [details] [diff] [review]
[checked in] pass in product name to verify-locales.pl

Looks good, r+

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 309956 [details] [diff] [review]
bootstrap patch to accomodate new verify-locales.pl

Redirected the same patch to different files ?

Comment 9

[[e-mail] (:bhearsum)]

Attachment: [checked in] the right patch

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 309961 [details] [diff] [review]
[checked in] the right patch

r+

Comment 11

[[e-mail] (:bhearsum)]

Hey Coop,

Can you land the verify-locales portion of this patch? I'll take care updating the masters.

Comment 12

[Chris Cooper [:coop] (he/him)]

Comment on attachment 309955 [details] [diff] [review]
[checked in] pass in product name to verify-locales.pl

Checking in verify-locales.pl;
/mofo/release/stage/verify-locales.pl,v  <--  verify-locales.pl
new revision: 1.9; previous revision: 1.8
done

Comment 13

[[e-mail] (:bhearsum)]

Comment on attachment 309961 [details] [diff] [review]
[checked in] the right patch

Checking in Bootstrap/Step/Stage.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Stage.pm,v  <--  Stage.pm
new revision: 1.35; previous revision: 1.34
done

Comment 14

[[e-mail] (:bhearsum)]

Alright, I've updated both production masters. I'm going to leave staging alone because it will break until the cvs mirrors are updated again. Nick, can you update stage ?

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #14)
> Alright, I've updated both production masters. I'm going to leave staging alone
> because it will break until the cvs mirrors are updated again. Nick, can you
> update stage ?

All done.

Comment 16

[[e-mail] (:bhearsum)]

I updated staging-1.8-master with the new code. I haven't done staging-1.9-master yet -- I had problems with it. No time to fix them today, I'll have a look tomorrow.

Comment 17

[[e-mail] (:bhearsum)]

Alright, staging-1.9-master is updated too.