Closed Bug 409232 Opened 12 years ago Closed 12 years ago

pass in product name to verify-locales.pl

Categories

(Release Engineering :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

Details

Attachments

(2 files, 1 obsolete file)

verify-locales.pl currently only supports Firefox releases. It will soon support Firefox Betas (bug 408868), but alphas are named differently. One way to solve this is to pass in the app name to verify-locales.pl. This has the additional benefit of being able to support Thunderbird (and other products?).

One thing I noticed is that Alpha naming may have to change a bit. Currently, installers on windows are named, ie, "Gran Paradiso Alpha 6.exe". To support this cleanly we could change that to "Gran Paradiso Setup Alpha 6.exe".
We could also integrate verify-locales.pl into Bootstrap, as we did with groom-files.
(In reply to comment #1)
> We could also integrate verify-locales.pl into Bootstrap, as we did with
> groom-files.
> 

I like this idea.
(In reply to comment #2)
> (In reply to comment #1)
> > We could also integrate verify-locales.pl into Bootstrap, as we did with
> > groom-files.
> I like this idea.
me too...
This is the script we run on stage, like this
  ~/bin/verify-locales.pl -m ../../batch-source/rc${RC}/mozilla/${APP}/locales/shipped-locales

rather than the l10n verify step in Bootstrap (metadiff).
Assignee: nobody → bhearsum
Priority: P3 → P2
Summary: pass in app name to verify-locales.pl → pass in product name to verify-locales.pl
Pretty straightforward patch, I think.
Attachment #309955 - Flags: review?(nrthomas)
Attachment #309956 - Flags: review?(nrthomas)
Comment on attachment 309955 [details] [diff] [review]
[checked in] pass in product name to verify-locales.pl

Looks good, r+
Attachment #309955 - Flags: review?(nrthomas) → review+
Comment on attachment 309956 [details] [diff] [review]
bootstrap patch to accomodate new verify-locales.pl

Redirected the same patch to different files ?
Attachment #309956 - Attachment is obsolete: true
Attachment #309956 - Flags: review?(nrthomas)
Attachment #309961 - Flags: review?(nrthomas)
Comment on attachment 309961 [details] [diff] [review]
[checked in] the right patch

r+
Attachment #309961 - Flags: review?(nrthomas) → review+
Hey Coop,

Can you land the verify-locales portion of this patch? I'll take care updating the masters.
Comment on attachment 309955 [details] [diff] [review]
[checked in] pass in product name to verify-locales.pl

Checking in verify-locales.pl;
/mofo/release/stage/verify-locales.pl,v  <--  verify-locales.pl
new revision: 1.9; previous revision: 1.8
done
Attachment #309955 - Attachment description: pass in product name to verify-locales.pl → [checked in] pass in product name to verify-locales.pl
Comment on attachment 309961 [details] [diff] [review]
[checked in] the right patch

Checking in Bootstrap/Step/Stage.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/Stage.pm,v  <--  Stage.pm
new revision: 1.35; previous revision: 1.34
done
Attachment #309961 - Attachment description: the right patch → [checked in] the right patch
Alright, I've updated both production masters. I'm going to leave staging alone because it will break until the cvs mirrors are updated again. Nick, can you update stage ?
(In reply to comment #14)
> Alright, I've updated both production masters. I'm going to leave staging alone
> because it will break until the cvs mirrors are updated again. Nick, can you
> update stage ?

All done.

I updated staging-1.8-master with the new code. I haven't done staging-1.9-master yet -- I had problems with it. No time to fix them today, I'll have a look tomorrow.
Alright, staging-1.9-master is updated too. 
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.