409298 - "ASSERTION: toString failed us" with XPCSafeJSObjectWrapper.prototype

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jesse Ruderman]

Loading the testcase triggers:

###!!! ASSERTION: toString failed us: 'type != JSTYPE_STRING', file /Users/jruderman/trunk/mozilla/js/src/xpconnect/src/XPCSafeJSObjectWrapper.cpp, line 646

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fixes

There were two problems:
* I didn't realize that we seal XPCSafeJSObjectWrapper.prototype, so resolving toString late, like we do doesn't work. To fix this, I resolve it before we cut off its parent and seal it.
* I moved the resolution of toString to after the prototype and security checks in XPC_SJOW_NewResolve to avoid unknown badness.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 294118 [details] [diff] [review]
Fixes

Easy followup to make SJOW prototypes happier.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 294118 [details] [diff] [review]
Fixes

a=beltzner for 1.9

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Add a mochitest

I decided to make test_xow.html be test_wrappers.html and add a couple of XPCSafeJSObjectWrapper to that file. I also noticed that I'd somehow managed to add a duplicate dirs directive to the makefile in xpconnect/tests, causing rules.mk to spit out a warning.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 294252 [details] [diff] [review]
Add a mochitest

Looks reasonable

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Mochitest checked in.