409327 - not recording bookmark visits as nsINavHistoryService::TRANSITION_BOOKMARK

Status: RESOLVED DUPLICATE of bug 409301

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

not recording bookmark visits as nsINavHistoryService::TRANSITION_BOOKMARK

We need to start call MarkPageAsFollowedBookmark(), like we do for MarkPageAsTyped()

we are depending on this for our global frecency algo, see bug #394038

note, we need to fix this typo in MarkPageAsFollowedBookmark(), which I have fixed locally:

-  mRecentTyped.Put(uriString, GetNow());
+  mRecentBookmark.Put(uriString, GetNow());

Comment 1

[Ed Lee :Mardak]

I'm guessing this will fix bug 409301 or just dupe that to this?

Comment 2

[(not reading, please use [e-mail] instead)]

wow, we logged those two hours apart, completely independently.

Comment 3

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv