Closed
Bug 409386
Opened 16 years ago
Closed 16 years ago
mozStorageArgvValueArray::GetString returns wrong length
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: ondrej, Assigned: ondrej)
References
Details
Attachments
(1 file)
1.35 KB,
patch
|
sdwilsh
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Function mozStorageArgvValueArray::GetString in storage/mozStorageValueArray.cpp assigns a value to nsAString & retval and sets the length to the number of bytes read from database. However, the length in bytes should be divided by 2 as can be seen in mozStorageStatementRowValueArray::GetString. This function will probably be used in bug #385245, so I'm adding a dependency.
Assignee | ||
Updated•16 years ago
|
Attachment #294206 -
Flags: review?(comrade693+bmo)
Comment 1•16 years ago
|
||
Comment on attachment 294206 [details] [diff] [review] Fix the returned length r=sdwilsh
Attachment #294206 -
Flags: review?(comrade693+bmo)
Attachment #294206 -
Flags: review+
Attachment #294206 -
Flags: approval1.9?
Updated•16 years ago
|
Attachment #294206 -
Flags: approval1.9? → approval1.9+
Updated•16 years ago
|
Keywords: checkin-needed
Comment 2•16 years ago
|
||
Thanks for the patch! Checking in storage/src/mozStorageValueArray.cpp; /cvsroot/mozilla/storage/src/mozStorageValueArray.cpp,v <-- mozStorageValueArray.cpp new revision: 1.5; previous revision: 1.4 done
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
You need to log in
before you can comment on or make changes to this bug.
Description
•