Closed
Bug 409411
Opened 17 years ago
Closed 17 years ago
Build ChatZilla locale pack when using --enable-ui-locale
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
Details
Attachments
(1 file)
|
962 bytes,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
I realized that my --enable-ui-locale=de SeaMonkey build I'm doing for testing did not build the new ChatZilla language pack. Some investigation made me realize we're just doing an ifneq involving the AB_CD var when it's not set yet as config.mk is only called afterwards through rules.mk.
The solution is to call config.mk before this ifneq, patch upcoming.
|
||
Updated•17 years ago
|
Summary: make ChatZilla locale pack be actually built with --enable-ui-locale → Build ChatZilla locale pack when using --enable-ui-locale
|
Assignee | |
Comment 1•17 years ago
|
||
Here's the patch, tested on my local build. Now a SeaMonkey built with --enable-ui-locale=de includes the langpack and uses German language for ChatZilla. Even if we don't use that way of building for release builds, it's good to have :)
Attachment #294241 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 294241 [details] [diff] [review]
patch: include config.mk early enough that the ifneq works
This looks good
Attachment #294241 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checked in, thanks!
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•