409463 - The flagtypes.description DB format is not the same in an upgraded installation and in a fresh one

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Frédéric Buclin]

Bug 153129 incorrectly upgrades installations:

>Index: Bugzilla/DB/Schema.pm
>+            description      => {TYPE => 'MEDIUMTEXT'},


>Index: Bugzilla/Install/DB.pm
>+    $dbh->bz_alter_column('flagtypes', 'description',
>+        { TYPE => 'MEDIUMTEXT', NOTNULL => 1 });


New installations have NOT NULL => 0 while upgraded ones have NOT NULL => 1.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

There's no reason to allow NULLs in the field, so the easiest solution is to make it NOTNULL. When creating new flag types, if you leave the description empty, they get an empty string for their description, not "NULL".

So I'm just making the field NOT NULL and ensuring that upgrades work properly if there are any NULLs in the field.

Comment 2

[Max Kanat-Alexander]

Okay, I've tested this all sorts of ways and it seems to fix things as far as I can see.

Comment 3

[Max Kanat-Alexander]

Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.95; previous revision: 1.94
done
Checking in Bugzilla/Install/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v  <--  DB.pm
new revision: 1.46; previous revision: 1.45
done