The flagtypes.description DB format is not the same in an upgraded installation and in a fresh one

RESOLVED FIXED in Bugzilla 3.2

Status

()

Bugzilla
Installation & Upgrading
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Frédéric Buclin, Assigned: Max Kanat-Alexander)

Tracking

({regression})

3.1.2
Bugzilla 3.2
regression
Bug Flags:
approval +
blocking3.1.3 +

Details

Attachments

(1 attachment)

v1
1.73 KB, patch
Max Kanat-Alexander
: review+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
Bug 153129 incorrectly upgrades installations:

>Index: Bugzilla/DB/Schema.pm
>+            description      => {TYPE => 'MEDIUMTEXT'},


>Index: Bugzilla/Install/DB.pm
>+    $dbh->bz_alter_column('flagtypes', 'description',
>+        { TYPE => 'MEDIUMTEXT', NOTNULL => 1 });


New installations have NOT NULL => 0 while upgraded ones have NOT NULL => 1.
Flags: blocking3.1.3+
(Assignee)

Updated

10 years ago
Assignee: installation → mkanat
(Assignee)

Comment 1

10 years ago
Created attachment 294390 [details] [diff] [review]
v1

There's no reason to allow NULLs in the field, so the easiest solution is to make it NOTNULL. When creating new flag types, if you leave the description empty, they get an empty string for their description, not "NULL".

So I'm just making the field NOT NULL and ensuring that upgrades work properly if there are any NULLs in the field.
Attachment #294390 - Flags: review+
(Assignee)

Comment 2

10 years ago
Okay, I've tested this all sorts of ways and it seems to fix things as far as I can see.
Status: NEW → ASSIGNED
Flags: approval+
(Assignee)

Comment 3

10 years ago
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.95; previous revision: 1.94
done
Checking in Bugzilla/Install/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v  <--  DB.pm
new revision: 1.46; previous revision: 1.45
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.