Channel link includes color (colour) codes

RESOLVED FIXED

Status

defect
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: rdmsoft, Assigned: Gijs)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.80])

Attachments

(1 attachment)

5.13 KB, patch
bugzilla-mozilla-20000923
: review+
Details | Diff | Splinter Review
Reporter

Description

12 years ago
I'm not sure, but I would guess this is a regression from bug 237538.

Reproduce: On a channel/network view, /echo %B#support%B
Expected: Link to irc://.../%23support
Actual: Link to irc://.../%23support%02

Updated

12 years ago
Summary: Channel link includes colour codes → Channel link includes color (colour) codes
Assignee

Comment 1

12 years ago
Posted patch PatchSplinter Review
Might as well remove the ugly hack that's been annoying me for ages. This should do Just Fine, as far as I've been able to tell.
Assignee: rginda → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #295514 - Flags: review?(silver)

Comment 2

12 years ago
Comment on attachment 295514 [details] [diff] [review]
Patch

>+    linkText = removeColorCodes(matchText);

Nit: needs 'var' keyword.

r=silver with nit fixed.
Attachment #295514 - Flags: review?(silver) → review+
Assignee

Comment 3

12 years ago
Checking in mozilla/extensions/irc/xul/content/mungers.js;
/cvsroot/mozilla/extensions/irc/xul/content/mungers.js,v  <--  mungers.js
new revision: 1.12; previous revision: 1.11
done
Checking in mozilla/extensions/irc/xul/content/static.js;
/cvsroot/mozilla/extensions/irc/xul/content/static.js,v  <--  static.js
new revision: 1.257; previous revision: 1.256
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.80]
You need to log in before you can comment on or make changes to this bug.