409587 - input[type="file"] cropped when narrow width specified

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[philippe (part-time)]

Attachment: test case

When a width of less than 250px is specified (on the widget), the button part of the widget is cropped.
e.g input[type="file"] {width:200px;}

regressed (tested: OS X 10.4.11):
Fails
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O 10.4; en-US; rv:1.9b2pre) Gecko/2007112702 Minefield/3.0b2pre
Camino Version 2007112701 (2.0a1pre)

Works
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O 10.4; en-US; rv:1.9b2pre) Gecko/2007112604 Minefield/3.0b2pre

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-11-26+04%3A00%3A00&maxdate=2007-11-27+00%3A00%3A00&cvsroot=%2Fcvsroot

regression from bug 363696, most likely

Comment 1

[philippe (part-time)]

Attachment: screen shot of test case

Comment 2

[Boris Zbarsky [:bzbarsky]]

Indeed.... We want to hide overflow in the vertical direction, but not in the horizontal direction here...

roc, do we have a sane way of doing that? 

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We could change the clip rect passed to OverflowClip to extend further out horizontally to include all child rects. Pretty easy... Matthew, can you handle this one?

Comment 4

[Matthew Gregan [:kinetik]]

Attachment: patch v1

Set the width of the clip rect to NS_UNCONSTRAINEDSIZE so that we only clip the height.  Reftest included.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I'm really not qualified to review this (esp since I'm not sure what the display list code does with that rect).  I hope we never pass it to a gfx Clip() call, right?

In any case, I think roc can just r+sr this.

Comment 6

[Matthew Gregan [:kinetik]]

Attachment: patch v2

Use the overflow rect's maximum width rather than NS_UNCONSTRAINED.

Comment 7

[Matthew Gregan [:kinetik]]

Comment on attachment 295723 [details] [diff] [review]
patch v2

Requesting approval.  Simple low risk fix for a recent regression.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 295723 [details] [diff] [review]
patch v2

a=beltzner for 1.9

Comment 9

[Reed Loden [:reed]]

Checking in layout/forms/nsFileControlFrame.cpp;
/cvsroot/mozilla/layout/forms/nsFileControlFrame.cpp,v  <--  nsFileControlFrame.cpp
new revision: 3.222; previous revision: 3.221
done
Checking in layout/reftests/reftest.list;
/cvsroot/mozilla/layout/reftests/reftest.list,v  <--  reftest.list
new revision: 1.94; previous revision: 1.93
done
RCS file: /cvsroot/mozilla/layout/reftests/forms/input-file-width-clip-1.html,v
done
Checking in layout/reftests/forms/input-file-width-clip-1.html;
/cvsroot/mozilla/layout/reftests/forms/input-file-width-clip-1.html,v  <--  input-file-width-clip-1.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/layout/reftests/forms/input-file-width-clip-ref.html,v
done
Checking in layout/reftests/forms/input-file-width-clip-ref.html;
/cvsroot/mozilla/layout/reftests/forms/input-file-width-clip-ref.html,v  <--  input-file-width-clip-ref.html
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/layout/reftests/forms/reftest.list,v
done
Checking in layout/reftests/forms/reftest.list;
/cvsroot/mozilla/layout/reftests/forms/reftest.list,v  <--  reftest.list
initial revision: 1.1
done

Comment 10

[philippe (part-time)]

verified with
Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008010720 Minefield/3.0b3pr