If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Whine should not add headers for queries with 0 bugs

RESOLVED FIXED in Bugzilla 3.2

Status

()

Bugzilla
Whining
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

unspecified
Bugzilla 3.2
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 294466 [details] [diff] [review]
simple fix

In a whine's e-mail, if there are no actual returned bugs, the whine is never sent. However if in a single whine with hundreds of queries, but only one bug, all the headers of each and every other query are still listed in the e-mail.

This is just unnecessary bloat.
Attachment #294466 - Flags: review?(LpSolit)
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Assignee: whining → bugspam.Callek
Status: ASSIGNED → NEW

Comment 1

10 years ago
Comment on attachment 294466 [details] [diff] [review]
simple fix

>+        unless ($thisquery->{'onemailperbug'} ||
>+                !@{$thisquery->{'bugs'}}) {

To make the logic easier to understand you should rather write:

 if (!$thisquery->{'onemailperbug'} && @{$thisquery->{'bugs'}}) {...}


r=LpSolit with this comment addressed.
Attachment #294466 - Flags: review?(LpSolit) → review+

Updated

10 years ago
Status: NEW → ASSIGNED
Flags: approval+
Target Milestone: --- → Bugzilla 3.2

Comment 2

10 years ago
Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.36; previous revision: 1.35
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 3

10 years ago
Created attachment 294471 [details] [diff] [review]
checked in patch
Attachment #294466 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.