409682 - Whine should not add headers for queries with 0 bugs

Status: RESOLVED FIXED

(Bugzilla :: Whining, defect)

Description

[Justin Wood (:Callek)]

Attachment: simple fix

In a whine's e-mail, if there are no actual returned bugs, the whine is never sent. However if in a single whine with hundreds of queries, but only one bug, all the headers of each and every other query are still listed in the e-mail.

This is just unnecessary bloat.

Comment 1

[Frédéric Buclin]

Comment on attachment 294466 [details] [diff] [review]
simple fix

>+        unless ($thisquery->{'onemailperbug'} ||
>+                !@{$thisquery->{'bugs'}}) {

To make the logic easier to understand you should rather write:

 if (!$thisquery->{'onemailperbug'} && @{$thisquery->{'bugs'}}) {...}


r=LpSolit with this comment addressed.

Comment 2

[Frédéric Buclin]

Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.36; previous revision: 1.35
done

Comment 3

[Frédéric Buclin]

Attachment: checked in patch