Closed
Bug 409743
Opened 17 years ago
Closed 16 years ago
Ukrainian builds
Categories
(Calendar :: Build Config, defect)
Calendar
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: tim.babych, Assigned: tim.babych)
Details
Attachments
(1 file)
331 bytes,
patch
|
sipaq
:
review+
|
Details | Diff | Splinter Review |
I checked in almost ready Ukrainian l10n of calendar, please add it to nightly builds for testing.
Comment 1•17 years ago
|
||
Comment on attachment 294504 [details] [diff] [review] add uk to all-locales r=sipaq
Attachment #294504 -
Flags: review+
Updated•17 years ago
|
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → 0.8
Version: Mozilla 1.8 Branch → unspecified
Comment 2•17 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 3•17 years ago
|
||
This checkin (probably) caused all MOZILLA_1_8_BRANCH locales are burning. Building machines are reporting: cvs server: cannot find module `l10n/uk/other-licenses/branding/sunbird' - ignored cvs [checkout aborted]: cannot expand modules Tim, you should check in /other-licenses/branding/sunbird files. And you should checkin whole calendar stuff to HEAD (trunk) too.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 4•17 years ago
|
||
Patch has been backed out to test the impact on the other l10n tinderboxen.
Assignee | ||
Comment 5•17 years ago
|
||
other-licenses/branding/sunbird checked into trunk and branch, calendar checked into trunk too.
Comment 6•17 years ago
|
||
Yep, this bug caused it, tinderboxen are reporting locales state correctly now.
Comment 7•17 years ago
|
||
Tim, how do you want to proceed? Should I try to enable the uk locale again? I also noticed that you checked in the complete English files and started to work from those. Be advised that the locale checks performed by the compare-locales script will be entirely useless for you, if you follow this path. The script will be unable to tell you, which string you have already been translated and which strings haven't been translated yet.
Assignee | ||
Comment 8•16 years ago
|
||
Hello again, Simon. Yes, please, reenable uk locale - it should be ok by now. I know the the script doesn't check for completeness of translation and does check only for technical validity. And as we're working on English files they are very unlikely to be invalid (unless, of course, they become a bit obsolete in the process). I just wanted to note that it should not cause compiling problems. Now I hope that point will be true, at least compiling xpi works fine. Happy New Year!
Comment 9•16 years ago
|
||
I re-enabled uk on the trunk and the MOZILLA_1_8_BRANCH for the moment. I will watch the l10n tinderboxen in the upcoming hours to see if the checkin had a noticeable impact (like last time) or not.
Updated•16 years ago
|
Assignee: nobody → tim.babych
Status: REOPENED → NEW
Comment 10•16 years ago
|
||
Seems to work this time without side-effects.
Status: NEW → RESOLVED
Closed: 17 years ago → 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•