409929 - Don't give "quit" focus/first responder status in the "Quit with active downloads" sheet

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Traditionally, the focus/initial first responder has been on "do no evil" buttons in two button alerts (and usually in three-button ones, too).

In the "Quit with active downloads" sheet, initial focus with FKA is on Quit.

This sheet is reversed since the default button is Don't Quit (non-destructive), so maybe giving Quit initial first responder status is OK.  Maybe it's not.  It seems like we've discussed this before, but I can't find the bug, so maybe I'm crazy.

Discuss.

Comment 1

[Mark Mentovai]

I think I'd rather the initial first responder be less destructive than "Quit", too.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Let's confirm this based on mento's comment, then.

Comment 3

[Mark Mentovai]

Attachment: Use nsAlertController to show a "destructive-action" dialog

I kind of wanted to add an equivalent of command-Q in this sheet to "Quit", but we don't really support custom equivalents anywhere else in nsAlertController either, and we've got bugs on those problems.

Comment 4

[Stuart Morgan]

Comment on attachment 299268 [details] [diff] [review]
Use nsAlertController to show a "destructive-action" dialog

>+      // In a normal dialog, the alternat button will map roughly to "Cancel",

Looks like one of those \e's stole from "alternate".

sr=smorgan

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mark, you'll get to checking this in when we get an open tree/server uptime this week?

Comment 6

[Mark Mentovai]

Oh, oops, I didn't check for new things to chicken while I was away.

Comment 7

[Mark Mentovai]

Chicked en on the trunk and MOZILLA_1_8_BRANCH before 1.6b3.