Closed
Bug 410036
Opened 17 years ago
Closed 17 years ago
DEBUG_CC build fails because InitMemHook is used before it is declared
Categories
(Core :: XPCOM, defect, P1)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: jruderman)
References
Details
(Keywords: regression)
Attachments
(1 file)
791 bytes,
patch
|
peterv
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
Building with "#define DEBUG_CC" uncommented (in the two .h files) gives me: /Users/jruderman/trunk/mozilla/xpcom/base/nsCycleCollector.cpp: In member function 'void nsCycleCollector::MarkRoots(GCGraph&, GCGraphBuilder&)': /Users/jruderman/trunk/mozilla/xpcom/base/nsCycleCollector.cpp:1365: error: 'InitMemHook' was not declared in this scope It looks like this is a regression from bug 401687: it added new caller to InitMemHook above its definition. My patch adds a forward-declaration for InitMemHook, so nothing has to be reordered.
Flags: blocking1.9?
Attachment #294712 -
Flags: superreview?(peterv)
Attachment #294712 -
Flags: review?(peterv)
Comment 1•17 years ago
|
||
Marking blocking just so we get this cleaned up
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
Priority: P3 → P1
Updated•17 years ago
|
Attachment #294712 -
Flags: superreview?(peterv)
Attachment #294712 -
Flags: superreview+
Attachment #294712 -
Flags: review?(peterv)
Attachment #294712 -
Flags: review+
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•