Color (colour) codes preceding a URL are ignored

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
minor
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: James Ross, Assigned: Gijs)

Tracking

({regression})

Trunk
regression

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.80])

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
A rather fun bug reported on IRC. If you stick a colour code right up against the start of a URL, it doesn't get found, e.g.:

  %C0http://example.com

This is a pain, since bug 371109 stopped codes anywhere in URLs, but at the start should be possible I think (I'd like it to work at the end too, but that's impossible to get right).

This could be fixed by adding "(index == 0) ||" to the ternary operator here:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/extensions/irc/xul/content/static.js&rev=1.254&mark=2785#2777
(Reporter)

Updated

10 years ago
Severity: normal → minor
Summary: Color (colour) codes preceeding a URL are ignores → Color (colour) codes preceeding a URL are ignored
Created attachment 295515 [details] [diff] [review]
Patch

As you wish. :-)
Assignee: rginda → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #295515 - Flags: review?(silver)
(Reporter)

Updated

9 years ago
Attachment #295515 - Flags: review?(silver) → review+
Checking in mozilla/extensions/irc/xul/content/static.js;
/cvsroot/mozilla/extensions/irc/xul/content/static.js,v  <--  static.js
new revision: 1.256; previous revision: 1.255
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Summary: Color (colour) codes preceeding a URL are ignored → Color (colour) codes preceding a URL are ignored
Whiteboard: [cz-0.9.80]
You need to log in before you can comment on or make changes to this bug.